From: Joe Perches <joe@perches.com>
To: Michael J Dilmore <michael.j.dilmore@gmail.com>, j.vosburgh@gmail.com
Cc: vfalico@gmail.com, andy@greyhouse.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [PATCH v2 net-next] bonding: Convert multiple netdev_info messages to netdev_dbg
Date: Tue, 20 Jun 2017 16:28:02 -0700 [thread overview]
Message-ID: <1498001282.12185.2.camel@perches.com> (raw)
In-Reply-To: <1497996331-24500-1-git-send-email-michael.j.dilmore@gmail.com>
On Tue, 2017-06-20 at 23:05 +0100, Michael J Dilmore wrote:
> The bond_options.c file contains several netdev_info messages that clutter kernel output. This patch changes all netdev_info messages
> to netdev_dbg and adds a netdev debug for the packets per slave parameter.
Hey Michael.
You should realign the multiple-line statements
to the open parentheses.
cheers, Joe
> diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
[]
> @@ -721,13 +721,13 @@ static int bond_option_mode_set(struct bonding *bond,
> const struct bond_opt_value *newval)
> {
> if (!bond_mode_uses_arp(newval->value) && bond->params.arp_interval) {
> - netdev_info(bond->dev, "%s mode is incompatible with arp monitoring, start mii monitoring\n",
> + netdev_dbg(bond->dev, "%s mode is incompatible with arp monitoring, start mii monitoring\n",
> newval->string);
Now all these are not aligned properly.
etc...
prev parent reply other threads:[~2017-06-20 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 22:05 [PATCH] [PATCH v2 net-next] bonding: Convert multiple netdev_info messages to netdev_dbg Michael J Dilmore
2017-06-20 23:28 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498001282.12185.2.camel@perches.com \
--to=joe@perches.com \
--cc=andy@greyhouse.net \
--cc=j.vosburgh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.j.dilmore@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox