From: Joe Perches <joe@perches.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>,
idryomov@gmail.com, sage@redhat.com, elder@kernel.org
Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: rbd: constify rbd_attr_group and rbd_opts_tokens
Date: Thu, 22 Jun 2017 05:23:00 -0700 [thread overview]
Message-ID: <1498134180.24295.2.camel@perches.com> (raw)
In-Reply-To: <a70b3cd481092b32ea362a885c4a54c4f50118e2.1498132969.git.arvind.yadav.cs@gmail.com>
On Thu, 2017-06-22 at 17:34 +0530, Arvind Yadav wrote:
> File size before:
> text data bss dec hex filename
> 43100 2161 64 45325 b10d drivers/block/rbd.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 43292 1969 64 45325 b10d drivers/block/rbd.o
If you are going to do these conversions, I still think
it'd be better to use a standard struct declaration.
>From 2011, (const was also added)
http://lkml.iu.edu/hypermail/linux/kernel/1104.2/00738.html
prev parent reply other threads:[~2017-06-22 12:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 12:04 [PATCH] block: rbd: constify rbd_attr_group and rbd_opts_tokens Arvind Yadav
2017-06-22 12:23 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498134180.24295.2.camel@perches.com \
--to=joe@perches.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox