From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754048AbdFWP7z (ORCPT ); Fri, 23 Jun 2017 11:59:55 -0400 Received: from smtprelay0095.hostedemail.com ([216.40.44.95]:49993 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752776AbdFWP7y (ORCPT ); Fri, 23 Jun 2017 11:59:54 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3874:4321:5007:7903:10004:10400:10848:11026:11232:11658:11914:12043:12296:12438:12555:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21433:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: burst73_563ffd4141047 X-Filterd-Recvd-Size: 2681 Message-ID: <1498233591.24295.16.camel@perches.com> Subject: Re: [PATCH] Staging : rts5208 : checkpatch.pl fixes From: Joe Perches To: Simo Koskinen , gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org Date: Fri, 23 Jun 2017 08:59:51 -0700 In-Reply-To: <20170623135548.GA21856@elsys-VirtualBox> References: <20170623135548.GA21856@elsys-VirtualBox> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-06-23 at 15:55 +0200, Simo Koskinen wrote: > Fixed some issues reported by checkpatch.pl script. [] > diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c > index b8177f5..ceef5fc 100644 > --- a/drivers/staging/rts5208/rtsx.c > +++ b/drivers/staging/rts5208/rtsx.c > @@ -1009,7 +1009,7 @@ static void rtsx_remove(struct pci_dev *pci) > { > struct rtsx_dev *dev = pci_get_drvdata(pci); > > - dev_info(&pci->dev, "rtsx_remove() called\n"); > + dev_info(&pci->dev, "%s called\n", "rtsx_remove()"); This would be better as dev_dbg > > quiesce_and_remove_host(dev); > release_everything(dev); > diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c > index 7f4107b..892b97a 100644 > --- a/drivers/staging/rts5208/rtsx_chip.c > +++ b/drivers/staging/rts5208/rtsx_chip.c > @@ -616,8 +616,10 @@ int rtsx_reset_chip(struct rtsx_chip *chip) > else > retval = rtsx_pre_handle_sdio_new(chip); > > - dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x (rtsx_reset_chip)\n", > - (unsigned int)(chip->need_reset)); > + dev_dbg(rtsx_dev(chip), "%s = 0x%x (%s)\n", > + "chip->need_reset", > + (unsigned int)(chip->need_reset), > + "rtsx_reset_chip"); This and other changes that take part of the format and convert them to '"%s", substrings' are not good. checkpatch doesn't emit a warning for long formats. > diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c [] > @@ -910,8 +910,12 @@ static int sd_change_phase(struct rtsx_chip *chip, u8 sample_point, u8 tune_dir) > int retval; > bool ddr_rx = false; > > - dev_dbg(rtsx_dev(chip), "sd_change_phase (sample_point = %d, tune_dir = %d)\n", > - sample_point, tune_dir); > + dev_dbg(rtsx_dev(chip), "%s (%s = %d, %s = %d)\n", > + "sd_change_phase", > + "sample_point", > + sample_point, > + "tune_dir", > + tune_dir); etc.