From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751922AbdF0CrF (ORCPT ); Mon, 26 Jun 2017 22:47:05 -0400 Received: from smtprelay0132.hostedemail.com ([216.40.44.132]:57808 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751445AbdF0CrC (ORCPT ); Mon, 26 Jun 2017 22:47:02 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3871:3872:4321:5007:6119:6238:6691:10004:10400:10848:11026:11232:11658:11914:12043:12048:12438:12555:12698:12737:12740:12760:12895:13069:13255:13311:13357:13439:13870:14659:14721:14915:21080:21451:21627:30051:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: wine08_5a20a75265701 X-Filterd-Recvd-Size: 1852 Message-ID: <1498531618.24295.57.camel@perches.com> Subject: Re: [PATCH] netfilter: ip_tables: remove useless variable assignment in get_info() From: Joe Perches To: "Gustavo A. R. Silva" , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 26 Jun 2017 19:46:58 -0700 In-Reply-To: <20170626223428.GA11614@embeddedgus> References: <20170626223428.GA11614@embeddedgus> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-06-26 at 17:34 -0500, Gustavo A. R. Silva wrote: > Value assigned to variable _ret_ at line 970 is overwritten either at > line 986 or 988, before it can be used. This makes such variable > assignment useless. > > Addresses-Coverity-ID: 1226932 [] > diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c [] > @@ -967,7 +967,7 @@ static int get_info(struct net *net, void __user *user, > struct xt_table_info tmp; > > if (compat) { > - ret = compat_table_info(private, &tmp); > + compat_table_info(private, &tmp); why isn't it more appropriate to test the return value? > xt_compat_flush_offsets(AF_INET); > private = &tmp; > }