From: Alan Cox <alan@linux.intel.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
Daniel Wagner <wagi@monom.org>,
David Woodhouse <dwmw2@infradead.org>,
rafal@milecki.pl, Arend van Spriel <arend.vanspriel@broadcom.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
yi1.li@linux.intel.com, atull@opensource.altera.com,
Moritz Fischer <moritz.fischer@ettus.com>,
pmladek@suse.com, Johannes Berg <johannes.berg@intel.com>,
emmanuel.grumbach@intel.com, luciano.coelho@intel.com,
Kalle Valo <kvalo@codeaurora.org>,
luto@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
"AKASHI, Takahiro" <takahiro.akashi@linaro.org>,
David Howells <dhowells@redhat.com>,
pjones@redhat.com, Hans de Goede <hdegoede@redhat.com>,
tytso@mit.edu, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] firmware: remove request_firmware_into_buf()
Date: Tue, 27 Jun 2017 13:54:26 +0100 [thread overview]
Message-ID: <1498568066.13921.18.camel@linux.intel.com> (raw)
In-Reply-To: <CAOCOHw4WYM66itYRmu35_AP9ZMoTvmXMqRmS5LfAcBNAGdZaow@mail.gmail.com>
On Mon, 2017-06-26 at 13:22 -0700, Bjorn Andersson wrote:
> On Fri, Jun 23, 2017 at 9:03 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > As Luis pointed out, there are no in-kernel users of
> > request_firmware_into_buf(), so remove it, and the now unused
> > internal
> > flag, which simplifies the logic around buffer handling a bit.
> >
>
> This API was implemented to reduce the memory pressure during
> firmware
> load in the Qualcomm remoteprocs, but it wasn't available when I
> upstreamed that code and I apparently forgot to send out the patch
> moving us over to use this API...
>
> Especially when loading the Qualcomm modem we have a couple of files
> that we request_firmware() that are 10-15MB in size, so this
> functionality is definitely wanted.
It may also at some point be very useful for FPGA partial reprogramming
- the FPGA bitstreams are *not* small and most FPGAs you don't need all
of it in kernel memory at the same moment.
Alan
prev parent reply other threads:[~2017-06-27 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 16:03 [PATCH] firmware: remove request_firmware_into_buf() Greg Kroah-Hartman
2017-06-26 20:22 ` Bjorn Andersson
2017-06-27 6:52 ` Greg Kroah-Hartman
2017-06-27 17:37 ` Bjorn Andersson
2017-07-12 23:44 ` Luis R. Rodriguez
2017-07-13 7:46 ` Greg Kroah-Hartman
2017-06-27 12:54 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498568066.13921.18.camel@linux.intel.com \
--to=alan@linux.intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=atull@opensource.altera.com \
--cc=bjorn.andersson@linaro.org \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=emmanuel.grumbach@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=johannes.berg@intel.com \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=luto@kernel.org \
--cc=mcgrof@kernel.org \
--cc=moritz.fischer@ettus.com \
--cc=pjones@redhat.com \
--cc=pmladek@suse.com \
--cc=rafal@milecki.pl \
--cc=rjw@rjwysocki.net \
--cc=takahiro.akashi@linaro.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=wagi@monom.org \
--cc=yi1.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox