From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751553AbdF1TXn (ORCPT ); Wed, 28 Jun 2017 15:23:43 -0400 Received: from smtprelay0192.hostedemail.com ([216.40.44.192]:37618 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751495AbdF1TXl (ORCPT ); Wed, 28 Jun 2017 15:23:41 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2840:2901:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4250:4321:5007:6119:7903:8957:10004:10400:10848:11232:11658:11914:12555:12740:12760:12895:13069:13095:13311:13357:13439:13869:14096:14097:14659:14721:21080:21212:21324:21433:21611:21627:30005:30045:30054:30056:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: end01_772f8aacfcd21 X-Filterd-Recvd-Size: 1990 Message-ID: <1498677816.8633.4.camel@perches.com> Subject: Re: [PATCH] mac80211_hwsim: use dyndbg for debug messages From: Joe Perches To: Lubomir Rintel , Johannes Berg Cc: Kalle Valo , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 28 Jun 2017 12:23:36 -0700 In-Reply-To: <1498677005.21787.1.camel@v3.sk> References: <20170628131726.15528-1-lkundrak@v3.sk> <1498662178.12531.6.camel@sipsolutions.net> <1498677005.21787.1.camel@v3.sk> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-06-28 at 21:10 +0200, Lubomir Rintel wrote: > On Wed, 2017-06-28 at 17:02 +0200, Johannes Berg wrote: > > On Wed, 2017-06-28 at 15:17 +0200, Lubomir Rintel wrote: > > > The mac80211_hwsim doesn't offer a way to disable the debugging > > > output. > > > Unfortunately, it's pretty chatty, dumping a lot of stuff into the > > > message buffer. > > > > Why is this a problem? It's pretty much a testing tool only, and much > > of the point is to have message about it's internal state? > > I do use it as a development tool. I find it very convenient to always > have a bunch of libvirt-managed LXC containers, some running hostapd > instances with various access point configurations and some used for > NetworkManager development and a mac80211_hwsim radio in each of them. > > An unfortunate side-effect is that my dmesg becomes next to useless due > to the overwhelming amount of mac80211_hwsim logging. Perhaps convert some of these to debugfs output? Otherwise, many or most of these seem to be function tracing type calls that could or should use ftrace.