From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751787AbdF2Fcq (ORCPT ); Thu, 29 Jun 2017 01:32:46 -0400 Received: from mga07.intel.com ([134.134.136.100]:6543 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751591AbdF2Fch (ORCPT ); Thu, 29 Jun 2017 01:32:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,278,1496127600"; d="scan'208";a="104980121" Message-ID: <1498714351.2510.35.camel@intel.com> Subject: Re: [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure From: Zhang Rui To: Bhumika Goyal Cc: Julia Lawall , Eduardo Valentin , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Jacob Pan Date: Thu, 29 Jun 2017 13:32:31 +0800 In-Reply-To: References: <1498028988-12916-1-git-send-email-bhumirks@gmail.com> <1498705219.2510.4.camel@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-06-29 at 10:41 +0530, Bhumika Goyal wrote: > On Thu, Jun 29, 2017 at 8:30 AM, Zhang Rui > wrote: > > > > On Wed, 2017-06-21 at 12:39 +0530, Bhumika Goyal wrote: > > > > > > Declare thermal_cooling_device_ops structure as const as it is > > > only > > > passed > > > as an argument to the function thermal_cooling_device_register > > > and > > > this > > > argument is of type const. So, declare the structure as const. > > > > > I checked the source and the code is written in this way as well in > > some other drivers, why not fix them altogether? > > > Hey, > > I have already sent the patches for the drivers requiring this > change. > Some of them got applied as well. I mean the other drivers that use thermal_cooling_device_ops. Surely I can applied this patch, but still it would be nice if you can check the other places that defines thermal_cooling_device_ops and fix all of them in one time. :) thanks, rui > > Thanks, > Bhumika > > > > > thanks, > > rui > > > > > > Signed-off-by: Bhumika Goyal > > > --- > > >  drivers/thermal/intel_powerclamp.c | 2 +- > > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/thermal/intel_powerclamp.c > > > b/drivers/thermal/intel_powerclamp.c > > > index d718cd1..e4c68b7 100644 > > > --- a/drivers/thermal/intel_powerclamp.c > > > +++ b/drivers/thermal/intel_powerclamp.c > > > @@ -659,7 +659,7 @@ static int powerclamp_set_cur_state(struct > > > thermal_cooling_device *cdev, > > >  } > > > > > >  /* bind to generic thermal layer as cooling device*/ > > > -static struct thermal_cooling_device_ops powerclamp_cooling_ops > > > = { > > > +static const struct thermal_cooling_device_ops > > > powerclamp_cooling_ops = { > > >       .get_max_state = powerclamp_get_max_state, > > >       .get_cur_state = powerclamp_get_cur_state, > > >       .set_cur_state = powerclamp_set_cur_state,