From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbdF2MIr (ORCPT ); Thu, 29 Jun 2017 08:08:47 -0400 Received: from mga06.intel.com ([134.134.136.31]:47453 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752143AbdF2MIk (ORCPT ); Thu, 29 Jun 2017 08:08:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,280,1496127600"; d="scan'208";a="1188478992" Message-ID: <1498738113.2510.40.camel@intel.com> Subject: Re: [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure From: Zhang Rui To: Bhumika Goyal Cc: Julia Lawall , Eduardo Valentin , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Jacob Pan Date: Thu, 29 Jun 2017 20:08:33 +0800 In-Reply-To: References: <1498028988-12916-1-git-send-email-bhumirks@gmail.com> <1498705219.2510.4.camel@intel.com> <1498714351.2510.35.camel@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-06-29 at 11:26 +0530, Bhumika Goyal wrote: > On Thu, Jun 29, 2017 at 11:02 AM, Zhang Rui > wrote: > > > > On Thu, 2017-06-29 at 10:41 +0530, Bhumika Goyal wrote: > > > > > > On Thu, Jun 29, 2017 at 8:30 AM, Zhang Rui > > > wrote: > > > > > > > > > > > > On Wed, 2017-06-21 at 12:39 +0530, Bhumika Goyal wrote: > > > > > > > > > > > > > > > Declare thermal_cooling_device_ops structure as const as it > > > > > is > > > > > only > > > > > passed > > > > > as an argument to the function > > > > > thermal_cooling_device_register > > > > > and > > > > > this > > > > > argument is of type const. So, declare the structure as > > > > > const. > > > > > > > > > I checked the source and the code is written in this way as > > > > well in > > > > some other drivers, why not fix them altogether? > > > > > > > Hey, > > > > > > I have already sent the patches for the drivers requiring this > > > change. > > > Some of them got applied as well. > > I mean the other drivers that use thermal_cooling_device_ops. > > > Actually, I also meant the same but maybe I wasn't clear enough :) > > > > > Surely I can applied this patch, but still it would be nice if you > > can > > check the other places that defines thermal_cooling_device_ops and > > fix > > all of them in one time. :) > > > I checked again and there remains only one file in power/supply where > thermal_cooling_device_ops can be made const. I will submit a patch > for it but I think I will have to create a separate patch because the > maintainers are different. > All other places are either already const > or I have submitted patches > for them am I in the loop of the patches? because I was not aware of those changes. thanks, rui > or cannot be made const. > > Thanks, > Bhumika > > > > > thanks, > > rui > > > > > > > > > Thanks, > > > Bhumika > > > > > > > > > > > > > > > thanks, > > > > rui > > > > > > > > > > > > > > > Signed-off-by: Bhumika Goyal > > > > > --- > > > > >  drivers/thermal/intel_powerclamp.c | 2 +- > > > > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/thermal/intel_powerclamp.c > > > > > b/drivers/thermal/intel_powerclamp.c > > > > > index d718cd1..e4c68b7 100644 > > > > > --- a/drivers/thermal/intel_powerclamp.c > > > > > +++ b/drivers/thermal/intel_powerclamp.c > > > > > @@ -659,7 +659,7 @@ static int > > > > > powerclamp_set_cur_state(struct > > > > > thermal_cooling_device *cdev, > > > > >  } > > > > > > > > > >  /* bind to generic thermal layer as cooling device*/ > > > > > -static struct thermal_cooling_device_ops > > > > > powerclamp_cooling_ops > > > > > = { > > > > > +static const struct thermal_cooling_device_ops > > > > > powerclamp_cooling_ops = { > > > > >       .get_max_state = powerclamp_get_max_state, > > > > >       .get_cur_state = powerclamp_get_cur_state, > > > > >       .set_cur_state = powerclamp_set_cur_state,