From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200AbdF2Na3 (ORCPT ); Thu, 29 Jun 2017 09:30:29 -0400 Received: from smtprelay0096.hostedemail.com ([216.40.44.96]:47607 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752748AbdF2NaV (ORCPT ); Thu, 29 Jun 2017 09:30:21 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3870:3871:3873:4321:5007:9010:10004:10400:10848:11232:11657:11658:11914:12043:12048:12740:12760:12895:13069:13161:13229:13311:13357:13439:14659:14721:21080:21433:21627:30029:30054:30070:30083:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: grape77_2a12c3861f13 X-Filterd-Recvd-Size: 2257 Message-ID: <1498743016.8633.14.camel@perches.com> Subject: Re: [PATCH] drivers/staging/media: Prefer using __func__ instead From: Joe Perches To: Pushkar Jambhlekar , Mauro Carvalho Chehab , Greg Kroah-Hartman , Tamara Diaconita , Jasmin Jessich , Ralph Metzler , Eva Rachel Retuya Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Thu, 29 Jun 2017 06:30:16 -0700 In-Reply-To: <1498735766-3068-1-git-send-email-pushkar.iit@gmail.com> References: <1498735766-3068-1-git-send-email-pushkar.iit@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-06-29 at 16:59 +0530, Pushkar Jambhlekar wrote: > Function name is hardcoded. replacing with __func__ Please run your proposed patches through checkpatch before you send them. > diff --git a/drivers/staging/media/cxd2099/cxd2099.c b/drivers/staging/media/cxd2099/cxd2099.c [] > @@ -100,7 +100,7 @@ static int i2c_read_reg(struct i2c_adapter *adapter, u8 adr, > .buf = val, .len = 1} }; > > if (i2c_transfer(adapter, msgs, 2) != 2) { > - dev_err(&adapter->dev, "error in i2c_read_reg\n"); > + dev_err(&adapter->dev, "error in %s\n", __func__); > return -1; > } > return 0; > @@ -115,7 +115,7 @@ static int i2c_read(struct i2c_adapter *adapter, u8 adr, > .buf = data, .len = n} }; > > if (i2c_transfer(adapter, msgs, 2) != 2) { > - dev_err(&adapter->dev, "error in i2c_read\n"); > + dev_err(&adapter->dev, "error in %s\n",__func__); There is a missing space before __func__. As well, the form for listing a function name is generally: print("%s: \n", __func__); so ideally, these messages would be something like: dev_err(&adapter->dev, "%s: i2c_transfer error\n", __func__);