From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751950AbdGBQNu (ORCPT ); Sun, 2 Jul 2017 12:13:50 -0400 Received: from smtprelay0160.hostedemail.com ([216.40.44.160]:39639 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751682AbdGBQNt (ORCPT ); Sun, 2 Jul 2017 12:13:49 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3873:4321:4384:5007:6119:7514:10004:10400:10848:11026:11232:11658:11914:12043:12296:12438:12740:12760:12895:13069:13095:13311:13357:13439:14181:14659:14721:21063:21080:21433:21451:21611:21627:30009:30029:30030:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: smash86_3fea54ddac40 X-Filterd-Recvd-Size: 1803 Message-ID: <1499012025.9885.5.camel@perches.com> Subject: Re: [PATCH] Replaced Function name in debug print with %s..., __func__ From: Joe Perches To: Gaurav Pathak , gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org Date: Sun, 02 Jul 2017 09:13:45 -0700 In-Reply-To: <1499004704-22473-1-git-send-email-gauravpathak129@gmail.com> References: <1499004704-22473-1-git-send-email-gauravpathak129@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-07-02 at 19:41 +0530, Gaurav Pathak wrote: > Signed-off-by: Gaurav Pathak Need a different subject like: [PATCH] staging: rts5208: Replace embedded function names with "%s: ", __func__ and you also require some change log like Avoid possible defects when refactoring. > diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c [] > @@ -3064,7 +3064,8 @@ static int mspro_rw_multi_sector(struct scsi_cmnd *srb, > > if (detect_card_cd(chip, MS_CARD) != STATUS_SUCCESS) { > chip->rw_need_retry = 0; > - dev_dbg(rtsx_dev(chip), "No card exist, exit mspro_rw_multi_sector\n"); > + dev_dbg(rtsx_dev(chip), "No card exist, %s\n", > + __func__); try not to change output too. You could also drop what appear to be function tracing style logging where the message is the equivalent of: void func(args...) { dev_dbg("%s: entered\n", __func__) ... } as the generic function tracing mechanism works well.