From: Kiran Gunda <kgunda@codeaurora.org>
To: Kiran Gunda <kgunda@codeaurora.org>,
Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
Stephen Boyd <sboyd@codeaurora.org>,
David Collins <collinsd@codeaurora.org>,
linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org
Subject: [PATCH V1 2/4] spmi: pmic-arb: fix a possible null pointer dereference
Date: Mon, 3 Jul 2017 18:22:16 +0530 [thread overview]
Message-ID: <1499086338-19498-3-git-send-email-kgunda@codeaurora.org> (raw)
In-Reply-To: <1499086338-19498-1-git-send-email-kgunda@codeaurora.org>
If "core" memory resource is not specified, then the driver could
end up dereferencing a null pointer. Fix this issue.
Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
---
drivers/spmi/spmi-pmic-arb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index f1851cb..86affb0 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -964,14 +964,14 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev)
pmic_arb->spmic = ctrl;
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core");
- pmic_arb->core_size = resource_size(res);
-
core = devm_ioremap_resource(&ctrl->dev, res);
if (IS_ERR(core)) {
err = PTR_ERR(core);
goto err_put_ctrl;
}
+ pmic_arb->core_size = resource_size(res);
+
pmic_arb->ppid_to_apid = devm_kcalloc(&ctrl->dev, PMIC_ARB_MAX_PPID,
sizeof(*pmic_arb->ppid_to_apid),
GFP_KERNEL);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-07-03 12:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 12:52 [PATCH V1 0/4]: spmi: pmic-arb: support for V5 HW and bug fixes Kiran Gunda
2017-07-03 12:52 ` [PATCH V1 1/4] spmi: pmic-arb: return __iomem pointer instead of offset Kiran Gunda
2017-07-06 6:51 ` Stephen Boyd
2017-07-03 12:52 ` Kiran Gunda [this message]
2017-07-06 6:52 ` [PATCH V1 2/4] spmi: pmic-arb: fix a possible null pointer dereference Stephen Boyd
2017-07-03 12:52 ` [PATCH V1 3/4] spmi: pmic-arb: add support for HW version 5 Kiran Gunda
2017-07-06 6:59 ` Stephen Boyd
2017-07-06 10:48 ` kgunda
2017-07-03 12:52 ` [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0 Kiran Gunda
2017-07-06 6:53 ` Stephen Boyd
2017-07-06 6:53 ` Stephen Boyd
2017-07-06 10:21 ` kgunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499086338-19498-3-git-send-email-kgunda@codeaurora.org \
--to=kgunda@codeaurora.org \
--cc=adharmap@codeaurora.org \
--cc=collinsd@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox