public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kiran Gunda <kgunda@codeaurora.org>
To: Kiran Gunda <kgunda@codeaurora.org>,
	Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	David Collins <collinsd@codeaurora.org>,
	linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, Fenglin Wu <fenglinw@codeaurora.org>
Subject: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0
Date: Mon,  3 Jul 2017 18:22:18 +0530	[thread overview]
Message-ID: <1499086338-19498-5-git-send-email-kgunda@codeaurora.org> (raw)
In-Reply-To: <1499086338-19498-1-git-send-email-kgunda@codeaurora.org>

From: Fenglin Wu <fenglinw@codeaurora.org>

The opc parameter in pmic_arb_write_cmd() function is defined with type
u8 and it's always greater than or equal to 0. Checking that it's not
less than 0 is redundant and it can cause a forbidden warning during
compilation. Remove the check.

Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org>
---
 drivers/spmi/spmi-pmic-arb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index bc88c19..b49e77a 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -417,7 +417,7 @@ static int pmic_arb_write_cmd(struct spmi_controller *ctrl, u8 opc, u8 sid,
 	/* Check the opcode */
 	if (opc >= 0x40 && opc <= 0x5F)
 		opc = PMIC_ARB_OP_WRITE;
-	else if (opc >= 0x00 && opc <= 0x0F)
+	else if (opc <= 0x0F)
 		opc = PMIC_ARB_OP_EXT_WRITE;
 	else if (opc >= 0x30 && opc <= 0x37)
 		opc = PMIC_ARB_OP_EXT_WRITEL;
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

  parent reply	other threads:[~2017-07-03 12:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03 12:52 [PATCH V1 0/4]: spmi: pmic-arb: support for V5 HW and bug fixes Kiran Gunda
2017-07-03 12:52 ` [PATCH V1 1/4] spmi: pmic-arb: return __iomem pointer instead of offset Kiran Gunda
2017-07-06  6:51   ` Stephen Boyd
2017-07-03 12:52 ` [PATCH V1 2/4] spmi: pmic-arb: fix a possible null pointer dereference Kiran Gunda
2017-07-06  6:52   ` Stephen Boyd
2017-07-03 12:52 ` [PATCH V1 3/4] spmi: pmic-arb: add support for HW version 5 Kiran Gunda
2017-07-06  6:59   ` Stephen Boyd
2017-07-06 10:48     ` kgunda
2017-07-03 12:52 ` Kiran Gunda [this message]
2017-07-06  6:53   ` [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0 Stephen Boyd
2017-07-06  6:53   ` Stephen Boyd
2017-07-06 10:21     ` kgunda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499086338-19498-5-git-send-email-kgunda@codeaurora.org \
    --to=kgunda@codeaurora.org \
    --cc=adharmap@codeaurora.org \
    --cc=collinsd@codeaurora.org \
    --cc=fenglinw@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox