From: Pawel Moll <pawel.moll@arm.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mark.rutland@arm.com, mingo@kernel.org
Subject: Re: [PATCH] bus: arm-ccn: constify attribute_group structures.
Date: Tue, 04 Jul 2017 12:27:01 +0100 [thread overview]
Message-ID: <1499167621.2752.16.camel@arm.com> (raw)
In-Reply-To: <8cc3d7884405d61c8c22f33db9c0ed5b61146899.1499066893.git.arvind.yadav.cs@gmail.com>
On Mon, 2017-07-03 at 13:01 +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 9074 5592 416 15082 3aea drivers/bus/arm-ccn.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 9327 5336 416 15079 3ae7 drivers/bus/arm-ccn.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Looks fine to me. I'll queue it for the next time I push out CCN driver
fixes (no dates promised, though...)
Thanks!
Paweł
prev parent reply other threads:[~2017-07-04 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 7:31 [PATCH] bus: arm-ccn: constify attribute_group structures Arvind Yadav
2017-07-04 11:27 ` Pawel Moll [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499167621.2752.16.camel@arm.com \
--to=pawel.moll@arm.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox