Re: [PATCH v3 4/5] selftests: ftrace: Output only to console with "--logdir -"

Steven Rostedt
2017-07-06T13:50:32Z

On Thu, 6 Jul 2017 18:10:58 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> @@ -255,12 +262,18 @@ __run_test() { # testfile
> # Run one test case
> run_test() { # testfile
> local testname=`basename $1`
> - local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> + if [ ! -z "$LOG_FILE" ] ; then
> + local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> + else
> + local testlog=`/proc/self/fd/1`

As Stafford mentioned. I don't think you want backticks here.

-- Steve

> + fi
> export TMPDIR=`mktemp -d /tmp/ftracetest-dir.XXXXXX`
> testcase $1