From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754340AbbLJJPL (ORCPT ); Thu, 10 Dec 2015 04:15:11 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:63595 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754192AbbLJJOh (ORCPT ); Thu, 10 Dec 2015 04:14:37 -0500 From: Arnd Bergmann To: xuejiancheng Cc: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, khilman@linaro.org, olof@lixom.net, xuwei5@hisilicon.com, haojian.zhuang@linaro.org, zhangfei.gao@linaro.org, bintian.wang@huawei.com, suwenping@hisilicon.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, yanhaifeng@hisilicon.com, gaofei@hisilicon.com, ml.yang@hisilicon.com, yanghongwei@hisilicon.com Subject: Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board Date: Thu, 10 Dec 2015 10:13:20 +0100 Message-ID: <1499414.DqYuOANrii@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56693EE2.20501@huawei.com> References: <1449110668-23647-1-git-send-email-xuejiancheng@huawei.com> <2721289.3GUub5trUg@wuerfel> <56693EE2.20501@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:we9wDE3yhDw+L63JY7578t8T27fBY+b9MHieVVVJ0KsL8oVqDdb MDIcI7TXv0adRTBNs0hwO4DHH253+hhA0qr+W5lhKSX9lHJ//rsi8JmqDJYm8mz7ctEQ57D WBIbo3u1TzdFWjOY1vdPnPhij7X4NpZIDe0ft4U393Y9CvOt9Iqh8GJPn6C+TwVJ7Nu8+Cu yAk775nXddM0KnYzJy2ZA== X-UI-Out-Filterresults: notjunk:1;V01:K0:7TgklBRexes=:6phl936kNBd6Qg3yvAb87o 9wEOj2GkHf+RT6t1vMw+ZzZi0WrMIxAneSYgUSCIu+0fN5Z2uRqHULVCKIf2mG5SYsoh68qEa Si+4LfJCT+3ysC5JoJhoOGuC4Y3mcDUK8wwQc6A5BsZWU04bmupNzV+3zfS6KRE3Y+OQ2+cSt rysEc/R0JNPPnbcQxmpeRMh+uM3PVG475tXPopZGY2T+LklOXsDIFgdP1MvsBPsJhC5sqsaAI 3euqQDeUwdfMxathisuYclpl5/Y6BlxWpdbrrWctJ2+WLMBjxszolpxqF8yavLXAbH2Q72dOO 72vs3UWGhVYW74V90wXgH7DPrLWEEJQ+nXPimGFAxMuKowFtNs8A2AyoLQp9rEiy4v0oH0LCj /sbyqmbCCUTv+xsTJK0ZQkqVzn19pBchorQ+tGzsKS9+uqmlfR/69SSaK6lo0d/30a++jN5UR baXYF2cp1FmDUz6H299D6rHv3vMCX0UYvQzIKA9lwBmAB9iSeP6GrLAxEt8I0rrXz33MbYyXd YHBfbt1xUyj8ku9LmtPvUeLEDvWWHabhL+LaiHg9hm08zYXKFgwRcUrdQZPl6MAo5bUDX0HJJ 91c6AD6x8WBtcaGQNjz0LU+GISCwWQAPvE1X41H2LQmqtXmc7+77VJ4JCEyeS6NvMEEwEghh7 xFRSF5i4Uo74qxwoD8ZKUllROK5mds4e2d/xG2+ttr+dElEpShGNLGHg1d+kTQpUMlNqT0Hk6 AgBdjPgIv9CRHeLr Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 10 December 2015 16:59:14 xuejiancheng wrote: > On 2015/12/10 16:04, Arnd Bergmann wrote: > > On Thursday 10 December 2015 14:32:05 xuejiancheng wrote: > >>> > >>> This is not what I meant. You have to use "syscon" as the most generic > >>> "compatible" value here, but should add a machine specific string > >>> as a more specific one. "hisilicon,sysctrl" is not appropriate because > >>> it does not identify the IP block uniquely, you can only use that > >>> in combination with another more specific string. > >> > >> OK. I will use "hisilicon,hi3519-syscon" and "syscon" as the compatible value > >> for the sysctrl node in hi3519.dtsi. > >> > > > > Why hisilicon,hi3519-syscon instead of hisilicon,hi3519-sysctrl? > > > Is this not called a sysctrl at all in the datasheet then? > > It is OK to use hisilicon,hi3519-sysctrl. > > I thought syscon was more commonly used as abbr. of system-controller in the kernel code. > > "syscon" is the generic name for the framework in the kernel. This has nothing to do with how chip designers call their devices, and the DT should always match what the datasheet says, not what a random operating system calls things, even if it's the only OS you care about. Arnd