* [PATCH] staging: atomisp: gc0310: constify acpi_device_id.
@ 2017-07-06 16:20 Arvind Yadav
2017-07-07 10:47 ` Alan Cox
0 siblings, 1 reply; 3+ messages in thread
From: Arvind Yadav @ 2017-07-06 16:20 UTC (permalink / raw)
To: mchehab, gregkh, alan; +Cc: linux-media, devel, linux-kernel
acpi_device_id are not supposed to change at runtime. All functions
working with acpi_device_id provided by <acpi/acpi_bus.h> work with
const acpi_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
10297 1888 0 12185 2f99 drivers/staging/media/atomisp/i2c/gc0310.o
File size After adding 'const':
text data bss dec hex filename
10361 1824 0 12185 2f99 drivers/staging/media/atomisp/i2c/gc0310.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/staging/media/atomisp/i2c/gc0310.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c b/drivers/staging/media/atomisp/i2c/gc0310.c
index 1ec616a..c8162bb 100644
--- a/drivers/staging/media/atomisp/i2c/gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/gc0310.c
@@ -1453,7 +1453,7 @@ static int gc0310_probe(struct i2c_client *client,
return ret;
}
-static struct acpi_device_id gc0310_acpi_match[] = {
+static const struct acpi_device_id gc0310_acpi_match[] = {
{"XXGC0310"},
{},
};
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: atomisp: gc0310: constify acpi_device_id.
2017-07-06 16:20 [PATCH] staging: atomisp: gc0310: constify acpi_device_id Arvind Yadav
@ 2017-07-07 10:47 ` Alan Cox
2017-07-08 22:34 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2017-07-07 10:47 UTC (permalink / raw)
To: Arvind Yadav, mchehab, gregkh; +Cc: linux-media, devel, linux-kernel
On Thu, 2017-07-06 at 21:50 +0530, Arvind Yadav wrote:
> acpi_device_id are not supposed to change at runtime. All functions
> working with acpi_device_id provided by <acpi/acpi_bus.h> work with
> const acpi_device_id. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex
> filename
> 10297 1888 0 12185 2f99
> drivers/staging/media/atomisp/i2c/gc0310.o
>
> File size After adding 'const':
> text data bss dec hex
> filename
> 10361 1824 0 12185 2f99
> drivers/staging/media/atomisp/i2c/gc0310.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/staging/media/atomisp/i2c/gc0310.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c
> b/drivers/staging/media/atomisp/i2c/gc0310.c
> index 1ec616a..c8162bb 100644
> --- a/drivers/staging/media/atomisp/i2c/gc0310.c
> +++ b/drivers/staging/media/atomisp/i2c/gc0310.c
> @@ -1453,7 +1453,7 @@ static int gc0310_probe(struct i2c_client
> *client,
> return ret;
> }
>
> -static struct acpi_device_id gc0310_acpi_match[] = {
> +static const struct acpi_device_id gc0310_acpi_match[] = {
> {"XXGC0310"},
> {},
> };
(All four)
Acked-by: Alan Cox <alan@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: atomisp: gc0310: constify acpi_device_id.
2017-07-07 10:47 ` Alan Cox
@ 2017-07-08 22:34 ` Sakari Ailus
0 siblings, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2017-07-08 22:34 UTC (permalink / raw)
To: Alan Cox; +Cc: Arvind Yadav, mchehab, gregkh, linux-media, devel, linux-kernel
On Fri, Jul 07, 2017 at 11:47:43AM +0100, Alan Cox wrote:
> On Thu, 2017-07-06 at 21:50 +0530, Arvind Yadav wrote:
> > acpi_device_id are not supposed to change at runtime. All functions
> > working with acpi_device_id provided by <acpi/acpi_bus.h> work with
> > const acpi_device_id. So mark the non-const structs as const.
> >
> > File size before:
> > text data bss dec hex
> > filename
> > 10297 1888 0 12185 2f99
> > drivers/staging/media/atomisp/i2c/gc0310.o
> >
> > File size After adding 'const':
> > text data bss dec hex
> > filename
> > 10361 1824 0 12185 2f99
> > drivers/staging/media/atomisp/i2c/gc0310.o
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > ---
> > drivers/staging/media/atomisp/i2c/gc0310.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c
> > b/drivers/staging/media/atomisp/i2c/gc0310.c
> > index 1ec616a..c8162bb 100644
> > --- a/drivers/staging/media/atomisp/i2c/gc0310.c
> > +++ b/drivers/staging/media/atomisp/i2c/gc0310.c
> > @@ -1453,7 +1453,7 @@ static int gc0310_probe(struct i2c_client
> > *client,
> > return ret;
> > }
> >
> > -static struct acpi_device_id gc0310_acpi_match[] = {
> > +static const struct acpi_device_id gc0310_acpi_match[] = {
> > {"XXGC0310"},
> > {},
> > };
>
> (All four)
>
> Acked-by: Alan Cox <alan@linux.intel.com>
There's four more... I've applied all to my atomisp branch.
Arvind: please send the patches as a single set next time.
--
Regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-08 22:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-06 16:20 [PATCH] staging: atomisp: gc0310: constify acpi_device_id Arvind Yadav
2017-07-07 10:47 ` Alan Cox
2017-07-08 22:34 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox