From: Oliver Neukum <oneukum@suse.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: isp1760: compress return logic into one line
Date: Mon, 10 Jul 2017 09:36:37 +0200 [thread overview]
Message-ID: <1499672197.12673.1.camel@suse.com> (raw)
In-Reply-To: <20170710020007.GA30095@embeddedgus>
Am Sonntag, den 09.07.2017, 21:00 -0500 schrieb Gustavo A. R. Silva :
> Simplify return logic to avoid unnecessary variable assignment.
>
> This issue was detected using Coccinelle and the following
> semantic patch:
>
Hi,
I need to ask: Where is the improvement? The compiler does not bother
and for the human reader you do not do anything obvious and you
decreased grepability.
Regards
Oliver
next prev parent reply other threads:[~2017-07-10 7:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 2:00 [PATCH] usb: isp1760: compress return logic into one line Gustavo A. R. Silva
2017-07-10 7:36 ` Oliver Neukum [this message]
2017-07-10 19:58 ` Gustavo A. R. Silva
2017-07-11 8:10 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499672197.12673.1.camel@suse.com \
--to=oneukum@suse.com \
--cc=garsilva@embeddedor.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox