From: Joe Perches <joe@perches.com>
To: AndyS <lkd1024@mail.ru>, gregkh@linuxfoundation.org
Cc: me@tobin.cc, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, shiva@exdev.nl
Subject: Re: [PATCH] Staging:ks7010:ks_wlan_net.c: unneeded type casting removed
Date: Mon, 10 Jul 2017 06:39:43 -0700 [thread overview]
Message-ID: <1499693983.5468.6.camel@perches.com> (raw)
In-Reply-To: <20170710070950.1693-1-lkd1024@mail.ru>
On Mon, 2017-07-10 at 10:09 +0300, AndyS wrote:
> removed undesired type casting. Warning was raised by checkpatch.pl
> This patch is for eudyptula challenge
False positive in checkpatch.
checkpatch does not handle floating point values.
> diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
[]
> @@ -208,7 +208,7 @@ static int ks_wlan_set_freq(struct net_device *dev,
> /* for SLEEP MODE */
> /* If setting by frequency, convert to a channel */
> if ((fwrq->e == 1) &&
> - (fwrq->m >= (int)2.412e8) && (fwrq->m <= (int)2.487e8)) {
> + (fwrq->m >= 2.412e8) && (fwrq->m <= 2.487e8)) {
> int f = fwrq->m / 100000;
> int c = 0;
>
next prev parent reply other threads:[~2017-07-10 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 7:09 [PATCH] Staging:ks7010:ks_wlan_net.c: unneeded type casting removed AndyS
2017-07-10 10:09 ` Frans Klaver
2017-07-10 10:31 ` kbuild test robot
2017-07-10 10:35 ` kbuild test robot
2017-07-10 13:39 ` Joe Perches [this message]
2017-07-10 13:51 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499693983.5468.6.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkd1024@mail.ru \
--cc=me@tobin.cc \
--cc=shiva@exdev.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox