From: Joe Perches <joe@perches.com>
To: Arnd Bergmann <arnd@arndb.de>, Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Greg Ungerer <gerg@linux-m68k.org>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] binfmt_flat: fix format string for u32
Date: Mon, 10 Jul 2017 08:49:03 -0700 [thread overview]
Message-ID: <1499701743.5468.13.camel@perches.com> (raw)
In-Reply-To: <20170710110832.667379-1-arnd@arndb.de>
On Mon, 2017-07-10 at 13:08 +0200, Arnd Bergmann wrote:
> The types have changed from 'unsigned long' to 'u32', so now the
> format string is wrong, and produces a harmless warning on arm32:
[]
> This changes it to '%d' instead, matching the 'u32' type.
[]
> diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
[]
> @@ -574,7 +574,7 @@ static int load_flat_file(struct linux_binprm *bprm,
> MAX_SHARED_LIBS * sizeof(unsigned long),
> FLAT_DATA_ALIGN);
>
> - pr_debug("Allocated data+bss+stack (%ld bytes): %lx\n",
> + pr_debug("Allocated data+bss+stack (%d bytes): %lx\n",
> data_len + bss_len + stack_len, datapos);
Ideally, %u not %d as data_len, bss_len and stack_len are all u32
prev parent reply other threads:[~2017-07-10 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 11:08 [PATCH] binfmt_flat: fix format string for u32 Arnd Bergmann
2017-07-10 15:49 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499701743.5468.13.camel@perches.com \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=gerg@linux-m68k.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox