From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932222AbdGJPtO (ORCPT ); Mon, 10 Jul 2017 11:49:14 -0400 Received: from smtprelay0176.hostedemail.com ([216.40.44.176]:51276 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932203AbdGJPtM (ORCPT ); Mon, 10 Jul 2017 11:49:12 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3867:3868:3871:3872:4321:5007:10004:10400:10848:11026:11232:11473:11658:11914:12296:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: steel77_6c78d3ccd4e02 X-Filterd-Recvd-Size: 1563 Message-ID: <1499701743.5468.13.camel@perches.com> Subject: Re: [PATCH] binfmt_flat: fix format string for u32 From: Joe Perches To: Arnd Bergmann , Alexander Viro Cc: Greg Ungerer , Nicolas Pitre , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 10 Jul 2017 08:49:03 -0700 In-Reply-To: <20170710110832.667379-1-arnd@arndb.de> References: <20170710110832.667379-1-arnd@arndb.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-07-10 at 13:08 +0200, Arnd Bergmann wrote: > The types have changed from 'unsigned long' to 'u32', so now the > format string is wrong, and produces a harmless warning on arm32: [] > This changes it to '%d' instead, matching the 'u32' type. [] > diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c [] > @@ -574,7 +574,7 @@ static int load_flat_file(struct linux_binprm *bprm, > MAX_SHARED_LIBS * sizeof(unsigned long), > FLAT_DATA_ALIGN); > > - pr_debug("Allocated data+bss+stack (%ld bytes): %lx\n", > + pr_debug("Allocated data+bss+stack (%d bytes): %lx\n", > data_len + bss_len + stack_len, datapos); Ideally, %u not %d as data_len, bss_len and stack_len are all u32