From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755829AbdGKMNX (ORCPT <rfc822;w@1wt.eu>);
        Tue, 11 Jul 2017 08:13:23 -0400
Received: from smtprelay0002.hostedemail.com ([216.40.44.2]:33664 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1755804AbdGKMNV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 11 Jul 2017 08:13:21 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3870:3871:4321:5007:7903:10004:10400:10848:11026:11473:11657:11658:11914:12043:12296:12679:12740:12760:12895:13069:13163:13229:13311:13357:13439:14181:14659:14721:21080:21627:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: grade79_1c475de9c3a25
X-Filterd-Recvd-Size: 2360
Message-ID: <1499775192.4457.10.camel@perches.com>
Subject: Re: [PATCH] staging: bcm2835-audio: remove more than 80 char error
From: Joe Perches <joe@perches.com>
To: Karuna Grewal <karunagrewal98@gmail.com>, linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org
Date: Tue, 11 Jul 2017 05:13:12 -0700
In-Reply-To: <20170711112914.GA4944@aakp-Lenovo-ideapad-500-15ISK>
References: <20170711112914.GA4944@aakp-Lenovo-ideapad-500-15ISK>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.6-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2017-07-11 at 16:59 +0530, Karuna Grewal wrote:
>     remove the more than 80 character error as pointed out by checkpatch by
>     spliting the statements at the separators in the statements .

Not every 80 column warning needs fixing.

Your selection of separators is poor.  For instance:

> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
[]
> @@ -116,14 +116,19 @@ static int snd_bcm2835_ctl_put(struct snd_kcontrol *kcontrol,
>  		return -EINTR;
>  
>  	if (kcontrol->private_value == PCM_PLAYBACK_VOLUME) {
> -		audio_info("Volume change attempted.. volume = %d new_volume = %d\n", chip->volume, (int)ucontrol->value.integer.value[0]);
> +		audio_info(
> +			"Volume change attempted.. volume = %d new_volume = %d\n",
> +	chip->volume, (int)ucontrol->value.integer.value[0]);

Better:

		audio_info("Volume change attempted.. volume = %d new_volume = %d\n",
			   chip->volume, (int)ucontrol->value.integer.value[0]);

[]

> -		if (changed || (ucontrol->value.integer.value[0] != chip2alsa(chip->volume))) {
> -			chip->volume = alsa2chip(ucontrol->value.integer.value[0]);
> +		if (changed || (ucontrol->value.integer.value[0] != chip2alsa(
> +			chip->volume))) {
> +			chip->volume =
> +			alsa2chip(ucontrol->value.integer.value[0]);

Better:
		if (changed ||
		    ucontrol->value.integer.value[0] != chip2alsa(chip->volume) {
			chip->volume = alsa2chip(ucontrol->value.integer.value[0]);
			changed = 1;
		}

etc...