[PATCH] leds: leds-aat1290.c: enclosed arithmetic expression macro

[PATCH] leds: leds-aat1290.c: enclosed arithmetic expression macro

[Lynn Lei]

Fixed the unenclosed complex values macro issue generated by
scripts/checkpatch.pl:
	ERROR: Macros with complex values should be enclosed in parentheses

Signed-off-by: Lynn Lei <lynnl.yet@gmail.com>
---
 drivers/leds/leds-aat1290.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c
index a21e19297745..061e2cfd8097 100644
--- a/drivers/leds/leds-aat1290.c
+++ b/drivers/leds/leds-aat1290.c
@@ -35,7 +35,7 @@
 #define AAT1290_MM_CURRENT_RATIO_ADDR	20
 #define AAT1290_MM_TO_FL_1_92		1
 
-#define AAT1290_MM_TO_FL_RATIO		1000 / 1920
+#define AAT1290_MM_TO_FL_RATIO		(1000 / 1920)
 #define AAT1290_MAX_MM_CURRENT(fl_max)	(fl_max * AAT1290_MM_TO_FL_RATIO)
 
 #define AAT1290_LATCH_TIME_MIN_US	500
-- 
2.13.2

Re: [PATCH] leds: leds-aat1290.c: enclosed arithmetic expression macro

[Joe Perches]

On Tue, 2017-07-11 at 23:23 +0800, Lynn Lei wrote:
> Fixed the unenclosed complex values macro issue generated by
> scripts/checkpatch.pl:
> 	ERROR: Macros with complex values should be enclosed in parentheses
[]
> diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c
[]
> @@ -35,7 +35,7 @@
>  #define AAT1290_MM_CURRENT_RATIO_ADDR	20
>  #define AAT1290_MM_TO_FL_1_92		1
>  
> -#define AAT1290_MM_TO_FL_RATIO		1000 / 1920
> +#define AAT1290_MM_TO_FL_RATIO		(1000 / 1920)
>  #define AAT1290_MAX_MM_CURRENT(fl_max)	(fl_max * AAT1290_MM_TO_FL_RATIO)

Nope, try again.

Look at one use of this macro and see how it could be
improved.  Think to yourself is AAT1290_MM_FL_RATIO a
useful define.  Think how adding parenthesis changes
AAT1290_MAX_MM_CURRENT.

checkpatch isn't always correct, but it can help
improved the code even if the messages it emits aren't
always intelligible.