From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>,
"nab@linux-iscsi.org" <nab@linux-iscsi.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mchristi@redhat.com" <mchristi@redhat.com>,
"roland@purestorage.com" <roland@purestorage.com>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"hare@suse.de" <hare@suse.de>
Subject: Re: [PATCH] iscsi-target: Reject immediate data underflow larger than SCSI transfer length
Date: Tue, 11 Jul 2017 16:17:05 +0000 [thread overview]
Message-ID: <1499789824.2586.16.camel@wdc.com> (raw)
In-Reply-To: <1499757761.28145.45.camel@haakon3.daterainc.com>
On Tue, 2017-07-11 at 00:22 -0700, Nicholas A. Bellinger wrote:
> So rejecting this case as already done in commit abb85a9b51 is the
> correct approach for >= v4.3.y.
Hello Nic,
I hope that you agree that the current target_cmd_size_check() implementation
is complicated and ugly. Patch 30/33 of the patch series I referred to in my
e-mail removes a significant number of lines of code from that function. So
my patch series not only makes target_cmd_size_check() easier to maintain and
to verify but it makes that function also faster. Hence please reconsider the
approach from my patch series. For patch 30/33, see also
https://www.spinics.net/lists/target-devel/msg15384.html.
Bart.
next prev parent reply other threads:[~2017-07-11 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 4:21 [PATCH] iscsi-target: Reject immediate data underflow larger than SCSI transfer length Nicholas A. Bellinger
2017-06-08 15:37 ` Bart Van Assche
2017-06-09 6:55 ` Nicholas A. Bellinger
2017-07-11 7:22 ` Nicholas A. Bellinger
2017-07-11 16:17 ` Bart Van Assche [this message]
2017-07-13 19:27 ` Nicholas A. Bellinger
2017-07-13 23:24 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499789824.2586.16.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchristi@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=roland@purestorage.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox