From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753924AbdGLQsq (ORCPT ); Wed, 12 Jul 2017 12:48:46 -0400 Received: from smtprelay0150.hostedemail.com ([216.40.44.150]:34638 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753903AbdGLQsp (ORCPT ); Wed, 12 Jul 2017 12:48:45 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:421:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3653:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6119:7903:8828:10004:10400:10848:11232:11658:11914:12295:12296:12740:12760:12895:13069:13095:13161:13229:13311:13357:13439:13869:14180:14659:14721:21067:21080:21433:21627:30005:30054:30056:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: berry42_11f13a588b455 X-Filterd-Recvd-Size: 1868 Message-ID: <1499878121.4457.33.camel@perches.com> Subject: Re: scripts/get_maintainer.pl misses maintainers sometimes From: Joe Perches To: Maarten Lankhorst Cc: LKML , Daniel Vetter Date: Wed, 12 Jul 2017 09:48:41 -0700 In-Reply-To: <6cd361d0-97b3-5bee-eb54-c4805fb16643@linux.intel.com> References: <6cd361d0-97b3-5bee-eb54-c4805fb16643@linux.intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-07-12 at 18:36 +0200, Maarten Lankhorst wrote: > Hello Joe Perches, > > I created a script for drm's maintainer-tools that pipes the output of get_maintainer.pl > to add the appropriate cc's to the commit message. It also ignores duplicates, so running > the script twice on the same commit doesn't add everyone twice. > > When testing, I found out that sometimes maintainers were added on the second patch, and > that made me notice a bug in get_maintainer.pl. > > On the below patch, I get up to 39 maintainers from get_maintainer.pl, but the actual amount > differs randomly on each invocation: > > ~/linux$ git show | scripts/get_maintainer.pl | wc -l > 39 > ~/linux$ git show | scripts/get_maintainer.pl | wc -l > 37 > ~/linux$ git show | scripts/get_maintainer.pl | wc -l > 38 > > Any idea why this happens? If you add --nogit --nogit-fallback to the command line the output is consistent. So it seems it comes down to that what git log outputs for the same command varies. I'll track it down further later.