From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yu-Chun Lin <eleanor.lin@realtek.com>,
afaerber@suse.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, lee@kernel.org, james.tai@realtek.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-realtek-soc@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
cy.huang@realtek.com, stanley_chang@realtek.com
Subject: Re: [PATCH 3/3] arm64: dts: realtek: Add Kent SoC and EVB device trees
Date: Wed, 5 Nov 2025 12:04:37 +0100 [thread overview]
Message-ID: <14b19124-ab99-4ee4-89c9-81e724c4b5bb@kernel.org> (raw)
In-Reply-To: <20251105104452.6336-4-eleanor.lin@realtek.com>
On 05/11/2025 11:44, Yu-Chun Lin wrote:
> Add Device Tree hierarchy for Realtek Kent SoC family:
>
> - kent.dtsi: base SoC layer
> - rtd<variant>.dtsi: SoC variant layer
> - rtd<variant>-<board>.dtsi: board layer
> - rtd<variant>-<board>-<config>.dts: board configuration layer
>
> Include RTD1501S Phantom EVB (8GB), RTD1861B Krypton EVB (8GB), and
> RTD1920S Smallville EVB (4GB).
>
> Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
> ---
> arch/arm64/boot/dts/realtek/Makefile | 5 +
> arch/arm64/boot/dts/realtek/kent.dtsi | 179 ++++++++++++++++++
> arch/arm64/boot/dts/realtek/rtd1501.dtsi | 13 ++
> .../boot/dts/realtek/rtd1501s-phantom-8gb.dts | 26 +++
> .../boot/dts/realtek/rtd1501s-phantom.dtsi | 135 +++++++++++++
> arch/arm64/boot/dts/realtek/rtd1861.dtsi | 13 ++
> .../boot/dts/realtek/rtd1861b-krypton-8gb.dts | 26 +++
> .../boot/dts/realtek/rtd1861b-krypton.dtsi | 79 ++++++++
> arch/arm64/boot/dts/realtek/rtd1920.dtsi | 13 ++
> .../dts/realtek/rtd1920s-smallville-4gb.dts | 24 +++
> .../boot/dts/realtek/rtd1920s-smallville.dtsi | 145 ++++++++++++++
> 11 files changed, 658 insertions(+)
> create mode 100644 arch/arm64/boot/dts/realtek/kent.dtsi
> create mode 100644 arch/arm64/boot/dts/realtek/rtd1501.dtsi
> create mode 100644 arch/arm64/boot/dts/realtek/rtd1501s-phantom-8gb.dts
> create mode 100644 arch/arm64/boot/dts/realtek/rtd1501s-phantom.dtsi
> create mode 100644 arch/arm64/boot/dts/realtek/rtd1861.dtsi
> create mode 100644 arch/arm64/boot/dts/realtek/rtd1861b-krypton-8gb.dts
> create mode 100644 arch/arm64/boot/dts/realtek/rtd1861b-krypton.dtsi
> create mode 100644 arch/arm64/boot/dts/realtek/rtd1920.dtsi
> create mode 100644 arch/arm64/boot/dts/realtek/rtd1920s-smallville-4gb.dts
> create mode 100644 arch/arm64/boot/dts/realtek/rtd1920s-smallville.dtsi
>
> diff --git a/arch/arm64/boot/dts/realtek/Makefile b/arch/arm64/boot/dts/realtek/Makefile
> index ef8d8fcbaa05..0ef0596681ad 100644
> --- a/arch/arm64/boot/dts/realtek/Makefile
> +++ b/arch/arm64/boot/dts/realtek/Makefile
> @@ -13,3 +13,8 @@ dtb-$(CONFIG_ARCH_REALTEK) += rtd1395-bpi-m4.dtb
> dtb-$(CONFIG_ARCH_REALTEK) += rtd1395-lionskin.dtb
>
> dtb-$(CONFIG_ARCH_REALTEK) += rtd1619-mjolnir.dtb
> +
> +dtb-$(CONFIG_ARCH_REALTEK) += rtd1501s-phantom-8gb.dtb
> +dtb-$(CONFIG_ARCH_REALTEK) += rtd1861b-krypton-8gb.dtb
> +dtb-$(CONFIG_ARCH_REALTEK) += rtd1920s-smallville-4gb.dtb
Keep things still ordered alphabetically.
> +
> diff --git a/arch/arm64/boot/dts/realtek/kent.dtsi b/arch/arm64/boot/dts/realtek/kent.dtsi
> new file mode 100644
> index 000000000000..6af3efa0bda4
> --- /dev/null
> +++ b/arch/arm64/boot/dts/realtek/kent.dtsi
> @@ -0,0 +1,179 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> +/*
> + * Realtek Kent SoC family
> + *
> + * Copyright (c) 2024 Realtek Semiconductor Corp.
> + */
> +
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +
> +/ {
> + interrupt-parent = <&gic>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + aliases {
> + serial0 = &uart0;
> + };
> +
> + arch_timer: arch-timer {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).
> + compatible = "arm,armv8-timer";
> + interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu0: cpu@0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a78";
> + reg = <0x0>;
> + enable-method = "psci";
> + next-level-cache = <&l2_0>;
> + dynamic-power-coefficient = <454>;
> + #cooling-cells = <2>;
> +
> + l2_0: l2-cache {
> + compatible = "cache";
> + cache-level = <2>;
> + cache-line-size = <64>;
> + cache-sets = <256>;
> + cache-size = <0x40000>;
> + cache-unified;
> + next-level-cache = <&l3>;
> + };
> + };
> +
> + cpu1: cpu@100 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a78";
> + reg = <0x100>;
> + enable-method = "psci";
> + next-level-cache = <&l2_1>;
> + dynamic-power-coefficient = <454>;
> + #cooling-cells = <2>;
> +
> + l2_1: l2-cache {
> + compatible = "cache";
> + cache-level = <2>;
> + cache-line-size = <64>;
> + cache-sets = <256>;
> + cache-size = <0x40000>;
> + cache-unified;
> + next-level-cache = <&l3>;
> + };
> + };
> +
> + cpu2: cpu@200 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a78";
> + reg = <0x200>;
> + enable-method = "psci";
> + next-level-cache = <&l2_2>;
> + dynamic-power-coefficient = <454>;
> + #cooling-cells = <2>;
> +
> + l2_2: l2-cache {
> + compatible = "cache";
> + cache-level = <2>;
> + cache-line-size = <64>;
> + cache-sets = <256>;
> + cache-size = <0x40000>;
> + cache-unified;
> + next-level-cache = <&l3>;
> + };
> + };
> +
> + cpu3: cpu@300 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a78";
> + reg = <0x300>;
> + enable-method = "psci";
> + next-level-cache = <&l2_3>;
> + dynamic-power-coefficient = <454>;
> + #cooling-cells = <2>;
> +
> + l2_3: l2-cache {
> + compatible = "cache";
> + cache-level = <2>;
> + cache-line-size = <64>;
> + cache-sets = <256>;
> + cache-size = <0x40000>;
> + cache-unified;
> + next-level-cache = <&l3>;
> + };
> + };
> +
> + l3: l3-cache {
> + compatible = "cache";
> + cache-level = <3>;
> + cache-line-size = <64>;
> + cache-sets = <512>;
> + cache-size = <0x00200000>;
> + cache-unified;
> + };
> + };
> +
> + psci: psci {
> + compatible = "arm,psci-1.0";
> + method = "smc";
> + };
> +
> + soc@0 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x00000000 0x00000000 0x00000000 0x00040000>, /* boot code */
> + <0x98000000 0x00000000 0x98000000 0x00ef0000>, /* reg-bus */
> + <0xa0000000 0x00000000 0xa0000000 0x10000000>, /* PCIE */
> + <0xff000000 0x00000000 0xff000000 0x00200000>; /* GIC */
> +
> + rbus: reg-bus@98000000 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).
> + compatible = "simple-bus";
> + reg = <0x98000000 0x00ef0000>;
This means it is not a simple-bus.
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x00000000 0x98000000 0x00ef0000>,
> + <0xa0000000 0xa0000000 0x10000000>; /* PCIE */
> +
> + iso: syscon@7000 {
> + compatible = "realtek,iso-system", "syscon", "simple-mfd";
> + reg = <0x7000 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x7000 0x1000>;
Please follow DTS coding style.
> + reg-io-width = <4>;
No children. You must post complete picture here.
> + };
> + };
> +
> + gic: interrupt-controller@ff100000 {
> + compatible = "arm,gic-v3";
> + reg = <0xff100000 0x10000>,
> + <0xff140000 0x80000>;
> + interrupt-controller;
> + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> + #address-cells = <1>;
> + #interrupt-cells = <3>;
> + #size-cells = <1>;
> + };
> + };
> +};
> +
> +&iso {
What are you overriding? There is no inclusion of other DTSI here.
> + uart0: serial@800 {
> + compatible = "snps,dw-apb-uart";
> + reg = <0x800 0x100>;
> + clock-frequency = <432000000>;
> + interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>;
> + reg-io-width = <4>;
> + reg-shift = <2>;
> + status = "disabled";
> + };
> +};
> +
> diff --git a/arch/arm64/boot/dts/realtek/rtd1501.dtsi b/arch/arm64/boot/dts/realtek/rtd1501.dtsi
> new file mode 100644
> index 000000000000..1df5d9843505
> --- /dev/null
> +++ b/arch/arm64/boot/dts/realtek/rtd1501.dtsi
> @@ -0,0 +1,13 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> +/*
> + * Realtek RTD1501 SoC
> + *
> + * Copyright (c) 2024 Realtek Semiconductor Corp.
> + */
> +
> +#include "kent.dtsi"
> +
> +&uart0 {
> + status = "okay";
> +};
> +
> diff --git a/arch/arm64/boot/dts/realtek/rtd1501s-phantom-8gb.dts b/arch/arm64/boot/dts/realtek/rtd1501s-phantom-8gb.dts
> new file mode 100644
> index 000000000000..b0e03f3731e2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/realtek/rtd1501s-phantom-8gb.dts
> @@ -0,0 +1,26 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> +/*
> + * Realtek RTD1501S Phantom EVB
> + *
> + * Copyright (c) 2024 Realtek Semiconductor Corp.
> + */
> +
> +/dts-v1/;
> +
> +#include "rtd1501s-phantom.dtsi"
> +
> +/ {
> + compatible = "realtek,phantom", "realtek,rtd1501s";
> + model = "Realtek Phantom EVB Chromium (8GB)";
> +
> + memory: memory@40000 {
Drop unused label.
> + device_type = "memory";
> + reg = <0x00000000 0x00050000 0x00000000 0x7ffb0000>,
0x0, don't inflate this.
> + <0x00000000 0x8a100000 0x00000000 0x0def0000>,
> + <0x00000000 0x98700000 0x00000000 0x07900000>,
> + <0x00000000 0xa0600000 0x00000000 0x5ea00000>,
> + <0x00000001 0x00000000 0x00000000 0xa0000000>,
<0x1 0x00000000 0x0 0xa0000000>,
> + <0x00000001 0xa0600000 0x00000000 0x5fa00000>;
> + };
> +};
> +
> diff --git a/arch/arm64/boot/dts/realtek/rtd1501s-phantom.dtsi b/arch/arm64/boot/dts/realtek/rtd1501s-phantom.dtsi
> new file mode 100644
> index 000000000000..bf1e499addf9
> --- /dev/null
> +++ b/arch/arm64/boot/dts/realtek/rtd1501s-phantom.dtsi
> @@ -0,0 +1,135 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> +/*
> + * Realtek RTD1501S Phantom EVB
> + *
> + * Copyright (c) 2024 Realtek Semiconductor Corp.
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/thermal/thermal.h>
> +#include "rtd1501.dtsi"
> +
> +/ {
> + chosen {
> + bootargs = "earlycon=uart8250,mmio32,0x98007800
> + console=ttyS0,460800 8250.nr_uarts=2 init=/init
> + loglevel=8 max_loop=64 loop.max_part=7
> + firmware_class.path=/vendor/firmware/,/vendor/av_fw";
NAK, drop all bootargs. None of above are suitable for mainline. Don't
post all this android or custom initramfs stuff.
> + stdout-path = "serial0:460800n8";
And you already even have here console!
> + };
> +
> + reserved_memory: reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + linux,cma {
> + compatible = "shared-dma-pool";
> + alignment = <0x0 0x00400000>;
> + alloc-ranges = <0x0 0x00000000 0x0 0x20000000>;
> + size = <0x0 0x02000000>;
> + reusable;
> + linux,cma-default;
> + };
> + };
> +
> + cpu_opps: opp-table-cpu {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp800: opp-800000000 {
> + opp-hz = /bits/ 64 <800000000>;
> + opp-microvolt = <830000 830000 1100000>;
> + status = "okay";
Why? Where did you disable it?
...
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-05 11:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 10:44 [PATCH 0/3] arm64: dts: Add support for Kent SoC family Yu-Chun Lin
2025-11-05 10:44 ` [PATCH 1/3] dt-bindings: arm: realtek: Add Kent Soc family compatibles Yu-Chun Lin
2025-11-05 10:44 ` [PATCH 2/3] dt-bindings: mfd: Add Realtek ISO system controller Yu-Chun Lin
2025-11-05 10:58 ` Krzysztof Kozlowski
2025-11-11 12:19 ` Eleanor Lin [林祐君]
2025-11-13 19:41 ` Krzysztof Kozlowski
2025-11-05 12:30 ` Rob Herring (Arm)
2025-11-11 12:29 ` Eleanor Lin [林祐君]
2025-11-05 10:44 ` [PATCH 3/3] arm64: dts: realtek: Add Kent SoC and EVB device trees Yu-Chun Lin
2025-11-05 11:04 ` Krzysztof Kozlowski [this message]
2025-11-11 12:25 ` Eleanor Lin [林祐君]
2025-11-13 19:40 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14b19124-ab99-4ee4-89c9-81e724c4b5bb@kernel.org \
--to=krzk@kernel.org \
--cc=afaerber@suse.de \
--cc=conor+dt@kernel.org \
--cc=cy.huang@realtek.com \
--cc=devicetree@vger.kernel.org \
--cc=eleanor.lin@realtek.com \
--cc=james.tai@realtek.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=robh@kernel.org \
--cc=stanley_chang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox