From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Daniel Gibson <daniel@gibson.sh>
Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Hans de Goede <hansg@kernel.org>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] Documentation/arch/x86/amd-debugging: Add section about delay_suspend
Date: Mon, 11 May 2026 15:49:43 +0300 (EEST) [thread overview]
Message-ID: <14ccefdc-eab5-b5a9-b8f1-1128bbf7f217@linux.intel.com> (raw)
In-Reply-To: <20260509013105.816339-6-daniel@gibson.sh>
On Sat, 9 May 2026, Daniel Gibson wrote:
> must be updated with the actual commit IDs when they are merged
Please write a proper changelog text.
Unfortunately, I cannot know the commit ID in advance as it depends on the
commit content itself (git object hashing works that way).
>
> Signed-off-by: Daniel Gibson <daniel@gibson.sh>
> ---
> Documentation/arch/x86/amd-debugging.rst | 25 ++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/Documentation/arch/x86/amd-debugging.rst b/Documentation/arch/x86/amd-debugging.rst
> index 3176a1240fee..3af7799cca1a 100644
> --- a/Documentation/arch/x86/amd-debugging.rst
> +++ b/Documentation/arch/x86/amd-debugging.rst
> @@ -249,6 +249,31 @@ state entry.
>
> `commit 40b8c14936bd2 ("drm/amd/display: Disable unneeded hpd interrupts during dm_init") <https://git.kernel.org/torvalds/c/40b8c14936bd2>`_
>
> +Keyboard and Lid Switch stop working after resume
> +-------------------------------------------------
> +On various variants of the Lenovo IdeaPad Slim 3 with Barcelo and Rembrandt CPUs
> +the lid switch and keyboard, or at least the Fn/Multimedia keys, stopped working
> +after resume, until the next reboot.
> +
> +This was caused by buggy firmware having timing problems, the EC needed some idle
> +time right before the CPU cores are suspended, or it got into an inconsistent state.
> +
> +For laptops that are known to be affected this workaround is enabled
> +automatically, to test this workaround on other machines you can set the
> +``delay_suspend`` parameter of the ``amd_pmc`` module.
> +
> +If you need to set the ``delay_suspend`` parameter to fix your machine, please
> +report this at platform-driver-x86@vger.kernel.org for it to be added to the
> +list of devices that need this workaround, so in future kernel versions it's
> +enabled automatically.
> +
> +Note that the current workaround isn't perfect: The problems can still happen
> +if resume is triggered by a timer (wakealarm).
> +
> +`commit TODO ("platform/x86/amd/pmc: Delay suspend for some Lenovo Laptops") <https://git.kernel.org/torvalds/c/TODO>`_
> +
> +`commit TODO ("platform/x86/amd/pmc: Add delay_suspend module parameter") <https://git.kernel.org/torvalds/c/TODO>`_
> +
> Runtime power consumption issues
> ================================
>
>
--
i.
next prev parent reply other threads:[~2026-05-11 12:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 1:30 [PATCH v2 0/5] amd_pmc: Delay s2idle suspend for some devices Daniel Gibson
2026-05-09 1:31 ` [PATCH v2 1/5] platform/x86/amd/pmc: Check for intermediate wakeup in function Daniel Gibson
2026-05-11 12:31 ` Ilpo Järvinen
2026-05-09 1:31 ` [PATCH v2 2/5] platform/x86/amd/pmc: Delay suspend for some Lenovo Laptops Daniel Gibson
2026-05-11 12:24 ` Ilpo Järvinen
2026-05-12 0:45 ` Daniel Gibson
2026-05-09 1:31 ` [PATCH v2 3/5] platform/x86/amd/pmc: Add delay_suspend module parameter Daniel Gibson
2026-05-11 12:36 ` Ilpo Järvinen
2026-05-09 1:31 ` [PATCH v2 4/5] Documentation/arch/x86/amd-debugging: Add example for reset register Daniel Gibson
2026-05-10 0:21 ` Mario Limonciello
2026-05-11 12:45 ` Ilpo Järvinen
2026-05-09 1:31 ` [PATCH v2 5/5] Documentation/arch/x86/amd-debugging: Add section about delay_suspend Daniel Gibson
2026-05-11 12:49 ` Ilpo Järvinen [this message]
2026-05-12 0:50 ` Daniel Gibson
2026-05-12 9:06 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14ccefdc-eab5-b5a9-b8f1-1128bbf7f217@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=daniel@gibson.sh \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox