From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4475316DEC3; Mon, 22 Jul 2024 15:18:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721661481; cv=none; b=RtMV7yqtgGItqg/WNSTpD1umYiUFTL2OIq/K8avuvkuGOFxYGJm2DrqKfhP1KjOIy591gXCWT4C7kbHvCmThKfXNi6c2af5ZwCyGTtOM/w+KthsFyQK/13oVcshAI3IUVjBHyHcZDmCJLElOnS6vV9UK2I0lG8X5UgBnFu8MENU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721661481; c=relaxed/simple; bh=e9Dnl+IUhEs+/M2CLtvFfu9EkQP4rlIJDzlw8s/gINE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FLDYUaIwyNnTNyfzKfoSPWkwCYGKT8VLhm2SgjnGT36exe56tKWcLgaxBxPMnpupVFYWP1id87w2nGl7CctmPziX155zxsolwf6ucTb0foTqKir2oiTkkwmS1XE7oaGbuFAHJdDzfgboGRot0nBKA1NrPEzuD5K9E0pRjdsZFTI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V1S0BT/t; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V1S0BT/t" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE622C116B1; Mon, 22 Jul 2024 15:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721661480; bh=e9Dnl+IUhEs+/M2CLtvFfu9EkQP4rlIJDzlw8s/gINE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=V1S0BT/thoR7gl3mK6fqWKlWvhvlFcqNlizOmaspuN2S4Wkg2wjy7MuwzDI3HQq9l JBOarwb4K/aQrguD2KdNwPh+N8MK2P2Q8Yvdp1s/S2sMrP/6GVXrR4N2TL3ObenY4F 2Lf+RTuUggf35ldmUx3cfU6vyBcXjxmEjK1eRpQr9F1lrNp9Z9v/8SgPBbr/EPYiC7 Y/j7g6fqqjg6xtTG+Cg1qGaxPJwY9dDIh0lDCnHV5E5TdjLsJ1DhUMhWjnQDGCp5QW mQUzgWrzkkjG/VSzmqtSQmxcG67SVC2CqFL0DeRXHcyW9H1k1K5eLwhZnFyzkGFZAb SMyPNvq+s7yuw== Message-ID: <14f53dce-e26e-4af3-9275-f2aef4e03c98@kernel.org> Date: Mon, 22 Jul 2024 17:17:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 3/6] dt-bindings: phy: cp110-utmi-phy: add compatible string for armada-38x To: Josua Mayer , Vinod Koul , Kishon Vijay Abraham I , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Konstantin Porotchkin Cc: Yazan Shhady , "linux-phy@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" References: <20240720-a38x-utmi-phy-v3-0-4c16f9abdbdc@solid-run.com> <20240720-a38x-utmi-phy-v3-3-4c16f9abdbdc@solid-run.com> <14090e3b-e627-4342-91b0-d6d0b769b736@solid-run.com> <55671e6b-abb3-4773-9f55-41920a3ff8f4@solid-run.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <55671e6b-abb3-4773-9f55-41920a3ff8f4@solid-run.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 22/07/2024 17:14, Josua Mayer wrote: > > Am 22.07.24 um 17:05 schrieb Josua Mayer: >> Am 21.07.24 um 11:31 schrieb Krzysztof Kozlowski: >>> On 20/07/2024 16:19, Josua Mayer wrote: >>>> Armada 38x USB-2.0 PHYs are similar to Armada 8K (CP110) and can be >>>> supported by the same driver with small differences. >>>> >>>> Add new compatible string for armada-38x variant of utmi phy. >>>> Then add descriptions and names for two additional register definitions >>>> that may be specified instead of a syscon phandle. >>>> >>>> Signed-off-by: Josua Mayer >>>> --- >>>> .../phy/marvell,armada-cp110-utmi-phy.yaml | 34 ++++++++++++++++++---- >>>> 1 file changed, 29 insertions(+), 5 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml >>>> index 9ce7b4c6d208..246e48d51755 100644 >>>> --- a/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml >>>> +++ b/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml > cut >>>> @@ -68,7 +93,6 @@ required: >>>> - reg >>>> - "#address-cells" >>>> - "#size-cells" >>>> - - marvell,system-controller >>> you miss here allOf:if:then: narrowing and marvell,system-controller per >>> each variant. > I am struggling a bit with the options. > > First attempt says: if not both usb-cfg and utmi-cfg reg-names are specified, > then marvell,system-controller is required. > > allOf: >   - required: That's not part of allOf. >       - compatible >       - reg >       - "#address-cells" >       - "#size-cells" >   - if: >       not: >         properties: >           reg-names: >             allOf: >               - contains: >                   const: usb-cfg >               - contains: >                   const: utmi-cfg >     then: >       required: >         - marvell,system-controller > > This works okay for any combinations of reg-names. ??? I expected this to be per variant. > > However when device-tree is missing reg-names all together, > marvell,system-controller is not marked required. > > Would it be acceptable to make reg-names required? I don't understand what you want to achieve. Best regards, Krzysztof