Re: [PATCH RFC v3 3/6] dt-bindings: phy: cp110-utmi-phy: add compatible string for armada-38x

Josua Mayer
2024-07-22T15:05:43Z

Am 21.07.24 um 11:31 schrieb Krzysztof Kozlowski:
> On 20/07/2024 16:19, Josua Mayer wrote:
>> Armada 38x USB-2.0 PHYs are similar to Armada 8K (CP110) and can be
>> supported by the same driver with small differences.
>>
>> Add new compatible string for armada-38x variant of utmi phy.
>> Then add descriptions and names for two additional register definitions
>> that may be specified instead of a syscon phandle.
>>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> ---
>> .../phy/marvell,armada-cp110-utmi-phy.yaml | 34 ++++++++++++++++++----
>> 1 file changed, 29 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml
>> index 9ce7b4c6d208..246e48d51755 100644
>> --- a/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml
>> @@ -23,12 +23,36 @@ description:
>> UTMI PHY1 --------\
>> 1.H----- USB HOST1
>>
>> + On Armada 380 there is an additional USB-2.0-only controller,
>> + and an additional UTMI PHY respectively.
>> + The USB device controller can only be connected to a single UTMI PHY port,
>> + either UTMI PHY0 or UTMI PHY2.
>> +
>> +
>> +
> One blank line is enough.
Ack.
>
>> properties:
>> compatible:
>> - const: marvell,cp110-utmi-phy
>> + enum:
>> + - marvell,a38x-utmi-phy
>> + - marvell,cp110-utmi-phy
>>
>> reg:
>> - maxItems: 1
>> + anyOf:
> That's oneOf.

Acknowledged, thanks!

Today oneOf seems correct to me, too.

>
>> + - items:
>> + - description: UTMI registers
>> + - items:
>> + - description: UTMI registers
>> + - description: USB config register
>> + - description: UTMI config registers
>> +
>> + reg-names:
>> + anyOf:
> oneOf
Ack.
>
>> + - items:
>> + - const: utmi
>> + - items:
>> + - const: utmi
>> + - const: usb-cfg
>> + - const: utmi-cfg
>>
>> "#address-cells":
>> const: 1
>> @@ -38,13 +62,14 @@ properties:
>>
>> marvell,system-controller:
>> description:
>> - Phandle to the system controller node
>> + Phandle to the system controller node.
>> + Optional when usb-cfg and utmi-cfg regs are given.
>> $ref: /schemas/types.yaml#/definitions/phandle
>>
>> # Required child nodes:
>>
>> patternProperties:
>> - "^usb-phy@[0|1]$":
>> + "^usb-phy@[0|1|2]$":
> [0-2]
Ack.
>
>> type: object
>> description:
>> Each UTMI PHY port must be represented as a sub-node.
>> @@ -68,7 +93,6 @@ required:
>> - reg
>> - "#address-cells"
>> - "#size-cells"
>> - - marvell,system-controller
> you miss here allOf:if:then: narrowing and marvell,system-controller per
> each variant.
Correct.
I will learn how to do that, and included it a non-rfc version.

Thanks!

sincerely
Josua Mayer