From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753921AbdGNKt7 (ORCPT ); Fri, 14 Jul 2017 06:49:59 -0400 Received: from mail-by2nam01on0080.outbound.protection.outlook.com ([104.47.34.80]:54539 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753557AbdGNKtz (ORCPT ); Fri, 14 Jul 2017 06:49:55 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; Message-ID: <1500029388.11612.54.camel@nxp.com> Subject: Re: [PATCH 2/4] thermal: imx: Add support for reading OCOTP through nvmem From: Leonard Crestez To: Srinivas Kandagatla CC: Shawn Guo , Zhang Rui , Eduardo Valentin , Rob Herring , Mark Rutland , Lothar =?ISO-8859-1?Q?Wa=DFmann?= , Fabio Estevam , "Dong Aisheng" , Bai Ping , Anson Huang , Octavian Purdila , , , Date: Fri, 14 Jul 2017 13:49:48 +0300 In-Reply-To: <3dd43cba-02f2-204c-c3a2-582827018ef8@linaro.org> References: <68b476b35b0c0cbce21da0e87338323bb77e9bc4.1499347157.git.leonard.crestez@nxp.com> <20170712063629.GD3172@dragon> <3dd43cba-02f2-204c-c3a2-582827018ef8@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131445029934126449;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39450400003)(39410400002)(39840400002)(39400400002)(39380400002)(39850400002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(377424004)(199003)(30594003)(24454002)(189002)(9170700003)(93886004)(23676002)(77096006)(104016004)(2870700001)(50466002)(5820100001)(54906002)(8936002)(356003)(85426001)(7416002)(2906002)(229853002)(86362001)(53546010)(53936002)(68736007)(105606002)(4326008)(81166006)(36756003)(498600001)(103116003)(50226002)(39060400002)(38730400002)(110136004)(6246003)(8676002)(50986999)(5660300001)(189998001)(8656002)(626005)(6916009)(2950100002)(76176999)(47776003)(33646002)(305945005)(106466001)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR03MB477;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDJGRk8xMU9MQzAwMTsxOjhyQWZycFFENlBzR0pnRlZCMk42ZDdMWXZJ?= =?utf-8?B?ZXhFNXFpOUVSbVhGdDVDanZ6NzRTenhpTVB0N0JjajFzbnRRYUxMRjZuSFVX?= =?utf-8?B?Y1ZDTlozR1ViOEFwZmoyeTdub3FJbnNiOHNYcjJEeDA0ME5qWDBrdFFYZnZr?= =?utf-8?B?UmVSZCt5czJ6Z0ZmTVljeTNEU3dVc1IyQ1pBWlRGdWJ1SmVMSGRITm91alJZ?= =?utf-8?B?RzlkMDNKVG84NlI5SE5JbjNDeWV5SnR3aGNuRWUxcjFsSFRjRWFlcEZSbTFy?= =?utf-8?B?MEdWMkE2SytCWWIxUzkwQlJFcllNc0U3S3Rab3FzUXpxdWNhV3FrOHlHR09w?= =?utf-8?B?RWxMdDFrT0NSQTNYNVZ5VUUrdlhJYzhCM2dmYXZ4MnNSbDViWk5HbWlCRTU4?= =?utf-8?B?SlNxNnUrTUlqSzR3ZEtHU2hFWlVuTU1Gd0x6eFU0Mk11OVMzUEZTYm1LYy95?= =?utf-8?B?Mm9xU1pBTmJ6TFYvbFNNN3BsaFYwRGdjVk5DQ3NDY3lNa3dpR0xNN01pTmRp?= =?utf-8?B?cGppSk1hUVdpYTdzUnorNzAwUWg0cytjTzgrbDFOWWErUmtoVnZVQXNtUDRQ?= =?utf-8?B?QUFTVDcyQ3dMWlVZd1V1eURLb25DbWpVRnJHRFBDbUkwL0FId0lpRGY4bVY0?= =?utf-8?B?Z3dhNVJ3bDdCMk1tNE5XQThEbS9tMk82ZFdYYjNrN3FpbW1IR1BockRnVHFl?= =?utf-8?B?NWhKc2hSeDhObnVNamhVTVFGZG0rSjlzd3h5VXcrMDJpcDlWSjM1R2pvVmxw?= =?utf-8?B?bml0Y051L0tmQk9RUGFNQkZQdXJtUTJaYTBFaHlXUHR3clluc0hMTE5PUmcx?= =?utf-8?B?OUp5TkkwZXJCUmdQSlRuVzBEcHBmMnZmYkpOVEZnTmF2WSs5ZVhWVlY5MHBo?= =?utf-8?B?NFc5WHpabUpaMjE5V0dib2k3WXQ3NWhlL2I5NWRLd2JUL0ZFeHZlcHlyZ1RZ?= =?utf-8?B?VGJJa3ZrUitGWlBqRTgrQm9hN2FOZ1lGRHdGczh5bVBpYkZHbXJIUHcySUJW?= =?utf-8?B?K2g0S3Q3bnVyejhCWGsvNnlRWEg2SUkyMWxHaStTaWdGV242ZUNHUDRRNHNE?= =?utf-8?B?L2YvRHN3c2NrSUlKR2laZWkzZHc0Ry9WVTVNQUlvdE15b2F6LzVuaG1ZSnhw?= =?utf-8?B?Qmd6Qlc5WVA5OFI2aVM0NzN3VnJjeU0vbWtvQWd4YWR5M3dIRkhKNTEyNjN4?= =?utf-8?B?L3puSkJrUWtidDBrZW1uWGN0L0ZDcDBlMXlSMHZtR2hLNmlwWDBxTmR5dGF0?= =?utf-8?B?TER5QmlOZmVwS3NGL0s2N2J2RTE5cFVqZHhCRUpvSFVHUC8wOHk3QVpEMHRk?= =?utf-8?B?azJtT0Rpd1NkaEE9PQ==?= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 81117237-da77-4332-d571-08d4caa60f2d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603031)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DM2PR03MB477; X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB477;3:qnCztlLf9AgWp8X8X+wio3eAjqcgcEl7w/nZ/pT6BDIX0lqAAAQ7LNwL45zL57vJcEVwfp3ugMkKOstJQyd6lN4OTLoIdjU7lQuQoQ6k8dgM44dWNVGGrh7xMm50Xp5D6yuQShQ/VQWJNQLWjmZRiFNPPQ3e0umMpEzQKoQQALf3iEpW0x4xSzYbhsgA2DqPvYo3T0QBfdnoDzmemTBEGboXJ6zQ5XgwYZ5M73UB7FuNJgYjA1Suv2wMEdkt53jmzWY4HZVS2WY5TaXpoCZJmlMJ/0LOVjjgQXCaGzXYtJmxf7v88yPi+OlbysDRKSL9BR0ovvxEwDn2xcRc8qLN+mcTy73L41MSw97TfiYbBcm/tqZAAKA9RhrOcnKwEHbibT0H/o4/QisHnQ04tPulRyk5g0GfeKVQnaurP3yyNY3FLLya3i5xJOVcnIs0W8TZAR9XEHOEMcnOd7h3A8pZWkDLZPPMggqqKVQwlyXUj1LCmTUwSmol9+E2wbSN5xPu6YexXQo8ptA1g/LKcK11uQveJEBYFbAYPrBMvWm8T0RNoXfdLklHsaIFmJVpjI3Z43feUz5RcAWs8PUDBPk4r7jTUx5CKDy0r2zsUS+KFPex5nOUIHHPzpJDpZAHlvAvVLFJf/xrba4hG8IZHOkOPwwOGnHux8wCKjAgIaJLN4isV5mbWdt1jnXxhqjP7mhSyqvd9dUk5ZMSL5/oq7VMOC0JJ+D2R7cfMIeY36/VXEA/+UzL/+8wstnNFqiXvxLbfRYODu5Cc17pS3Jfpd4joTTFlPSkQLRbEVv8WuNpLpIlOP7dK/EFggwKZ5YlZEnQlqbDL7VizJi0xYR16fn0z18arm/KoKuw123w+Fi1lLeExA/PSySRBYQyZ+pL8gNV X-MS-TrafficTypeDiagnostic: DM2PR03MB477: X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB477;25:qj81vULMcwL2A4582OykRBbyiR5ni0wr642gbcuN51JMl6zzNPaCxR6UrdMbs3BAoL6zoVQvFMaCWy1LwfHny4ULoGlS5UrKZcBB+TdrU2NRYth+qYY4lPiicSNsIdQvqxEaZLsMe77mLkkQzoxdA2d1DiuVPaQymDjy2BV9x9kuZYVku6bJ6yPbmTae8w7EoUIXt/39D+Y5Q+mY+TbT5wKT+subxmcgms79SsA53vgXQ7t08xNAdXnQgDd0oVN2AGaVCCtU4p2m5xiaEANRyK6HxASH14gsYXZs3F51K94i0sy4A3nT/D8V4rOqw5AuaRZvSsUImD6N0UFFphc/zGjGamvlWz5dvavVZhRJ5RrTVn+nDdMw0mIYdo4sgkV+1f66dQNBDyxl2zvwnbNWFy7BHhN5yQjRxFShTiZJM9+39VFxRoPyUDCz7xSiooCenCA+NyLIPDzyCULta/oT/am1Cy7sSGkC5n5HPSrZsrWFK/3IpXniFxpbapBiDDcl90v4Mb8g0jmN7O4Qf11wMWGGDomgqMuRP52/nHeFHPxWx9bqkfMHTxMSgH4eKUocfr5hMt+KRvCslgbjzDd8EC/+ip+7IMTdwW3y1i3Y1tWd8pLJFqojwxr8HDnGqLhtOOwJNehdviVokEmSk4JCuM1KCmwFi/6zZHBxp0Mqxt5SmhBS24ptDdHX/MK0B3Y4UwQU7yK//fbjOXMVx2uvBq4L5e+6/8PC/IYM7u92dQRF4CeV9UJa9bbcp9YQWIz43i2rGD7Sa9uc1Z84VFv2sXJ+8TO76XhqFgTtuSYT5jG0+fB8H5TGIr+pmYnZtiZAvJSDWhZCqksmT6tpk+gc0AplgKN3PDIfKsQn5fZERJ0xE9vgec+souucIDl9GV269ImM8n3DO/1Z2x/akr9dffYRrN7ylYFkLjNN7TbJqg8= X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB477;31:0FtaJzY1MIDGFd5QYIXTDD4vf1flUxEfUizWzKFdrccuAhg9DiuW0o+/vTHS4KdbAy2XBpwFmeSdZ1bTi4g9WIdZQmh//KiAukPdH2WxN8kXel9MZ110DpWuGZccFekjvY8BQ48dse9wjN5Uk1rUQMbQbdggL8icHchlvOGKlv2Rj2ehA9kpPsKPqlx8oOQcVPlxkMhUnRalw3z5e1BY2Djl/2fqujW9U0IlOpyB48AV0MA64CAX6RKXyO8BZsYyK6/NWLmTL+hG+31U9vbkkpyp28QRPOJERmIFgIK3bYQY2XUz9ox3U/TeADNXY9a/3Yud9poRtYNcIn+TXq5MUq5f4RtWUjJEyEAWDQixL9pUJ+NQEluHfu6mDF4/QRpgfdkttDE5iQ2i5bI7xZDnN6mL9C8Z+A9qrJEUrFdp286Cf3sz/mj3edE6LgF3tQpQRD3Uj2ZU6SuqcCIqzBLMbbHRMwj/Jkcu7gBjMU9PusjM8j9Ccs2eQfhP6kQK1XOSR7+VmD5LrZCD0Oadr7r4paOfsd65gm9Ip6UDC533RAnibiF6mEcfTwHD8viwW01Cy1j8ar8hwAvdBxBU6T1pdzoY94BhjNFVw+rlCQ2sz7G6B1gswJ6unDBmzN1hyTCdiaVTsisqYArJZKCo6Wq8v7pYXAw8+Zs+9MzCJJBaZBz21iGDMsoW6NOKWkFfzRRGaYl3Rw7eaxPl97Hf9jSTaQ== X-Exchange-Antispam-Report-Test: UriScan:(133145235818549)(236129657087228); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(2017060910075)(13018025)(13016025)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6055026)(6096035)(20161123565025)(20161123561025)(20161123563025)(20161123559100)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123556025)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM2PR03MB477;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM2PR03MB477; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjAzTUI0Nzc7NDpQS2RCbThUZDhsbTMwOUMyN2pXYnRYVUkyTjA0?= =?utf-8?B?UnlsR3JES2Zwc1laQVc5TmZLOHhQZFJHanNPN0VicmlaSEdncWhGU094c0Jv?= =?utf-8?B?V1ZCeXkvRzkwNnU2bG5BTHBVZ2ZGTGtqWUNhV2l5UzYrZGdieisvczdTVjB1?= =?utf-8?B?ekFvODgyclpVTUxBek1janlRMUVDWHJqdDlOejdBbEVOcmVSc2lRdWV0TEJT?= =?utf-8?B?UTVYZklaeGN3N3FEaElNbTlqV1VlRlNwZzRiVDd2VmVocGNsSjZ0WFBwTm5K?= =?utf-8?B?T0tRSVB3ZDJ6cUN1L1JHQ2xmMG9QVUVJeU8vem03a0pZZmJ4RUFuV0JlN3FI?= =?utf-8?B?M3JRMW5QQURoWUl6YU44SU1vM3QyWnR2Tkw2Y0tidnk3aSt6L3Njb0twc3pU?= =?utf-8?B?YmE2dVlMVHhkSjl1UUhXaStlS3ZjeTdhRFdDako4VzJwamludTh1UFQ5a1RX?= =?utf-8?B?YnU4Z3VtMWMyaWxocE5NMjJVWnptQWVpek83TTl0NlRvWktyUHczcTZsN0RQ?= =?utf-8?B?cG43a2hmWFI4c0didlZpbUdoblo4NGdKaW9XTWgzdXNsckZRRDI3WHhEVFI4?= =?utf-8?B?RzJVWUN6OWxPNFBDR0ZWUWpqV0hKMU5oM2xzTHVwRU5ud09oV0JMamp2TzNV?= =?utf-8?B?RWM3L1VsMHNZNndSL1BpaXliTE41TWlzNGJyc1J1aEhabXFRSEcveWxzdlA0?= =?utf-8?B?Ulc4SnlKNmFNam41SnBTV0d4YWFPT0FtKyswUzdNeU1DdmFtYXJ2QTZxMHBI?= =?utf-8?B?SUxvcGJNamtHVUR0WnVUSWtjVGxMK24xcWFSZlBENnhkMFp0SXVPWTc0dnZJ?= =?utf-8?B?STZVeG95OW5wNVk0Z2NkY1hVV2JXaFhEWmFMTjRpcEZ4cERNSjVGN2FjUTRJ?= =?utf-8?B?L3dGQ1VXUWdmZFl6U2FRYnljRk9BZkNLOWNyL0hXSE9FRXdPT0h6eng0NkJu?= =?utf-8?B?SlExQmx3NWFoNnMzbmF1U2c1NXE4UDBzSUhJS1JQTDlERGg0U3U4QTdHVmNB?= =?utf-8?B?UlZlOFc4R0ltMDJHNVgrb0dYcFgrYklRNjZGTzJFS3dPV3RkejdrTXZqL0th?= =?utf-8?B?YzdyMWgrRmJYcUFpSEtLdGM1ZlJ6RXdOcWNRMytWODIyTk1wRlFxU0pvMUYx?= =?utf-8?B?aFlWa1Vsa0R6Z21TNWtHa0xISUVkYU1tQW1EdDFmVUFyTHBodTdKS3JsNkts?= =?utf-8?B?VDNMTUZRVE9IdG05bCtCQzNuRWlIMzZMTmNzZEpHNEhBYy9naEFKT1oxY3RP?= =?utf-8?B?UjB5Z05oQzc3ckZxbEdXYnNQREZuSVJPWXdFNklESzBLUElORzdUL0VsY2Zw?= =?utf-8?B?NHhIRVhXeUFIZzRONjdITTBxazRTMURwa2NGRCtmVEhKRzlmR1Q5Q1ZBUGpn?= =?utf-8?B?aW13YU1JN2srYW1Db3FubDVtc3dlMzdWQS9MNXJJcXdhLzk0ME9tOWNPSHh5?= =?utf-8?B?M0xwQ3JaT29UbkZKMWsxZXU1ZzhNU1k4NnBCWXIvL0NGRlRucUNtTlpDNVJp?= =?utf-8?B?aVM2RU1vRTMwQk50bEl6aWpVNlJiWE5XanVydDFYYWZNQ1VGcXpKdFY3QlRn?= =?utf-8?B?UlU0MjRhbkJsZWFxWk5LVytxUVZTVmZPVmNvNkhRRWJsOC9aekcvTjQyOFhi?= =?utf-8?B?Y2F6NXRYRVkrZUMvMGE1N2x5dERreGQxMkl0R05WSVh5UXV2bGJsUm5PejBZ?= =?utf-8?B?UGVjWjNOZ1NvWXV5MTZYY2U2Ynh2b0dRWDhYMXVEaE5oOVBWWW9TdWFpMjJ4?= =?utf-8?B?L2dBL05IVGVWNld5OFpKaW9WeHZtQ2JpT2lJcXJCejUycVh3ODErUHQraUd2?= =?utf-8?Q?3KrA+U2XdOH?= X-Forefront-PRVS: 0368E78B5B X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjAzTUI0Nzc7MjM6OUdVdXU1WElrMDJReVNGSlJQVzVsYlo3a2Y4?= =?utf-8?B?YXNQK1V4ZFFhVjJDSnNqVnhiL2dXMmIzc3BUbUpkTG5CbWl6V2l4dElSYVB3?= =?utf-8?B?QjlZY1NIRTZoY0FzSmZmL3hMRTZnRldpbHI0VXRTaWFFZGlPRzMwWDlhVnE2?= =?utf-8?B?MCs5NWVoK252KzlhWFZuNzUrMFZnTkFxMDdoN0hrdFI4TW9hY2NsOTNwM1pH?= =?utf-8?B?RXlGRFo1UWxTNWJMeEkyVVRnQzZWS1VLUzJFbU9CN2JmeTlWclBCYXoyS0hq?= =?utf-8?B?OFF1UldQektjbjVMTkJRR01GaTJJOHBRaWRXUy9sN0ZBck9DMW15MHBZcEg1?= =?utf-8?B?SWh3YXNJcFFicE45VU9BalZjL0NweDRadkpJUExBZEViYmhqdnQzQ0VwS1dp?= =?utf-8?B?MG1KaG13WDRxQUtzS2xTWVhjMVVmVkFWUHZxdzRCTlFQOTBMbDV1ZzdLNytq?= =?utf-8?B?eERTczBqMnNrdm4wWUgxbmZITFpNcFRWM0hVVnlFVTE5MEhpMTNieHNpd2la?= =?utf-8?B?UFYrWjQ4S1FIWW54UE42dWZxY1lacGhrK1loeTRzNG9zZ0djZE1LZ056d05I?= =?utf-8?B?S1pYTjZsc1hDb0RWWElSM1dHemR4L051UTBRS2NjNGNTNUN0Nkg0Q0FNRUh4?= =?utf-8?B?SGU1aVNoMUViYUJyS2duSEVrRTIzZGtrU2pweVg5S205VENEM0N4NkxhSUZs?= =?utf-8?B?L3hsR0k5Q21RZy90TEpTMFdIb2Vsa0JyYzhwVnRqcWZ1ckV2c0RzWWVTVUkv?= =?utf-8?B?N3BHWms4SUtjRnFNTkZrTmtYOUFxOFJrVit2bi9vSkFMY1NjOEVQU1VhU2Nw?= =?utf-8?B?eEkxczdQdXVRemZRaTZEWklwZEcrb2lXRFd0Y1BFZXp2Z2NVVzh4alNSNklO?= =?utf-8?B?dUxUQ1MxcmdVUldzZUxMdnpHcGpKYU9ZRGNOVWRkdjhTNld5S1ZaeDJlMmQx?= =?utf-8?B?T0EyK0x3Skc2bGxONndXdHdJTEpGc2gyUXJPYVRNV0pJZmllbDZ6MDNrRzZ2?= =?utf-8?B?cC9UWTRpeDJOMFQwK2hhWWlYNXZ1RTJwUnpGYjM5K2tmSFFTdERma2VjZ21X?= =?utf-8?B?QU02QWFkQnRZTjJMY3k4YnJtK2pSY0cxWmN2dEhSWXNOK2RMUUdaQ254Wm5B?= =?utf-8?B?SEpQYkw3SHJ2T21pQ2tLYlZXQ0FON3FIYm5QUGNpQmg4WkRibFpML2VzMzBT?= =?utf-8?B?RS83YWNBazdqTVYrR3YxaEc0aTZXSmlWbW4rQ2Z4R1FhUVhjcHJRR2NHU0do?= =?utf-8?B?RnUrREF6UFZxNDBUTm5EMUNtcnFBLzVSeWR5bzRPem16d1lZUU1KNUZicERP?= =?utf-8?B?dWpDbjB4SFdUbjNtdmpvN2JYdWVHOUM4YzBvQ3AwT0o1WER1VUs4dFZZUzVs?= =?utf-8?B?aXowWDZORFJsaFlOWWJZMTFQc1d4OHBkci9qa0c3c1ZjQitvMm1xM3c4OWor?= =?utf-8?B?NngxZnM0Mjc4VEpsamhJS3p4TnRma3EwcDFmTWlLaVZFaWQyWVdYamcxVHFN?= =?utf-8?B?bWhNR01zMWRUSXd0a1l4SGt5aGNCbGhIQ2kyU1F2VjhMY2Z6MDFjQ1JqSDl0?= =?utf-8?B?c2FYQVBicTg5UGtObHFMbVZROUcwTnBhQlFvWWx2UmtkN2ZLWE5XT1IreUN5?= =?utf-8?B?T2Z4Y3F6dDhITjdhZkZZRnF4NlhNUy83dVlaWEJXNnNwci9WOG9ZQVFMbEtZ?= =?utf-8?B?VUF1U0JtSTFRaiswRGxnUkl3c1NPL2poZXB6cm5wdTd5N1RnVCtWWFZ1NWlr?= =?utf-8?B?cDk0UFVWbis0Y0pwSmF5bDVWb0hGbEJCV2FDTWphdFI5MG9ubThYVytLS1do?= =?utf-8?B?bzlxRzNtcXUwQVVBcjRPOHg0SHdjZmhKalpRNld1MThHNTZMVURMSkEvU3RC?= =?utf-8?B?Q0Y5eWtiT1lXaENqTFRvM2dMWE95YmFvaGJLRnA4QXlWcFNFa2duVjZpa005?= =?utf-8?B?S2N1SEFVaEc3RFFJVlBqbHU0V2JVTXlSNm94c3dMbEd1ekppcTc2SDdnRmhH?= =?utf-8?B?ZjEwTGxGMFd5dHdUVFF6Rjh2N3p0N1d6ZTV6Yy9NUUsvWmNVcnNNQTkyRFpj?= =?utf-8?Q?PzQ=3D?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjAzTUI0Nzc7NjptMDN2K3UwWHlpV2VkSFJTSTJhci8yeDdBVmlr?= =?utf-8?B?ZzhJeXlJREFEa3R1ZmJZSDl4aWtyWFR4cHIvbDFheWNET1loUjdtcHQ4L1VR?= =?utf-8?B?alJGQXRPOVh5S0RrUnF4S1dhR3NBckFHSWtrVEErYm9icGNnVzc2c0cvS0hH?= =?utf-8?B?WFFIVGF6ZjBBVEJQa3g2bWpvUHhJWUZiZk5uNE02U2duSkhKWnZkc3JtSVR6?= =?utf-8?B?ckZhdEMwZVhNcW1JK3FmVjA1ZmxWeDBnKzN3elVCTlVrM1VqcGpmYit0UUND?= =?utf-8?B?WENUaG9wQkxZS3JRbDk2Si9FZytuQW1JMHc0d1MwWG5ML1dibkI0dmVtRmZh?= =?utf-8?B?SXo4djQvT3Jaa3RBTnE1VXZlUDYybzFydXVtSDVrSnQreVhSSkNQQzlUMHdj?= =?utf-8?B?M3BxL0YvdDBDK1BvN3ZFSTl1Z2k4V3RBNkNNbXZtSzhNOU9ZN3VsQXNuV1VX?= =?utf-8?B?cVZQK3V1RysrblZkUzNKQjRNVXMxSk0xaitCM3pkT2dDaXB5eklOTXBwV2U5?= =?utf-8?B?N0hHWTZuZnhwaTVyNlVpNk1BSnpPY0cweS9GREkva2svS1h4VTZvS0cwSzBw?= =?utf-8?B?V1VzaW9WbENnZFgyOHJ6NnUvY0o3eEZGVllKTXJBSElxNU5KY2FteEw4dFZ3?= =?utf-8?B?YVRkYnVYWE85dkdpYW42MFVocE4xV1lkVzZTK3BaeEtxcHlieG5EREN5aFJF?= =?utf-8?B?aC85L2hXTTNmWWwzM3NhVG9kSVExaXMxTVdZTGpZSkdjQlB4empmcERUZFla?= =?utf-8?B?M3RwVU9Rb0NrelMwZ0RJbkdkY2xKTUJOczRyYXJCU28xUjFVY09aVlRtRUdp?= =?utf-8?B?TmRSS3ExOTVXMXUxWlNrSUxlWkNTZzZ0WEIrbTNwa1RuTS9tQ0JvMHdKbU1r?= =?utf-8?B?alh6Z201NGh6dGN3Tk9Kc1RFanBRRDA5Y04rL2lFNFRNR1FKa05EVXovNWY4?= =?utf-8?B?ZUwvUE9YV01lRDFJYnUybEZEUzVrUXhmUWUyRzk0bXNRbllFeHZ6SmJycU9E?= =?utf-8?B?aUtma1lVWFpXTVJxNkVRaG5jcCtWNnBPaWt6STJtMGxLUWozR1hXZlJZdEZX?= =?utf-8?B?Z1ZhNzQ3bkF5WEZxbDRNSjZCOVpvMXNQTUpidEpzYWJnb0YyQnJSbmJIZlFa?= =?utf-8?B?VEZ1T0JVblZ2V1NWNVhFV0pzQm5jcG1SRzgrQmlwUjJBMmVxWEl0dHBhdmd1?= =?utf-8?B?S0Jtem84WElkSTVKeG5sanNhZUpBaVdENVd1TFhiK29ncGJXUUhTL1VtQ2dm?= =?utf-8?B?VWNTU1o2OUljYlN0Z29zOTUzSlJYb2t5dHdtd29rYVRzRm1DNE5KaWhrUlV5?= =?utf-8?B?TDJCY0Q0V2Z3PT0=?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB477;5:c4HoKAfY4Ts0aKnlRAMIjPfW1v3HXjgIvGEPzAyhRoPxVkC9nWBp1mt7ZG03qauSZY9aYvoVYjC3WnIRR2A5g5uolqtoJDIrwUy4wDM3iG+vX90jauFCGZAaBqmZfN5NMZW2fPq49F0ui378KqCR3Vv0kajpUsbENbGBhwHhqEKECbumfKxkrgnZKYkD8Pi8X12a/Ilj40t6Kx+iw01L+LxJyKcokssqM+MtgJpdtB/70GjGk7vV1WZtyGpR3f71pqdAELYyU7pPAsPo23GAx2fJCNyOcVJu0xG26ABxISBKnBi5CmKXn/eKkjm0R3o5HbzlzyLy9uw5SEoExGLZv+7IrlgdK3S1fXslVnsiPIF9No3LVX6FuwuTLK2g+NzhXkbxTNoNO5FGgU/fFFBVVH0pWx8UoruulwEK4BRPjPp1rKIvl5y5c0LiqStjhFpwtimDzzb2dLgeeKS2KYs8Id+E/yVqZGOl/nTh9H5rqiZ+HJ72SqQZUBeaqK2LyTAWY0yQzDwayJtvqswMVUgoKQ==;24:UNtw6o30Qt7xnqxB7pQ3WqYt/S5jTwDiVkS5ur/I4p+kmRrDlgVz26dLxvZOS+F0qrB4b7pzeHQFsdURf3GitURk6dYEZMs/4gZzMJYOD7o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR03MB477;7:lnbDfrV+X/4zLEVa4fbHWNPVZy5qFIcm5xpiOt6zr0LUhfyDxwnr2fwj9heKaciQNaRaP53Hv8q5faj89LpycLgG/ZW9WeDzkMByKXlfDPJMvYNCPFELRniOMS2RpGhm16fgdtVqcbfdDCG1owenS+uWcd1GyxYseNyRfXEmD4UBjYBwbw+R3dBhUEhsIpGPWf2P7IB9g2jzMQ5FkDRBfns6aUk/NMI162fpAqc2SxHcqTacJXgNFN+yU5B8Ah30g43WuY/+IDM5w1aYxwHIMnTR9IWUwcINfFmgcKbPRNfVycjGXeUStSGrgjSVd42kCy+y22hJJ0s/oqGuo/r+1nWKk+h40tVzz589zCeQ4ElDAF5XXzXTX8IUEmstOenvF3N3ZHWMB3IzsfLXLzNWtsgV7y+8zp/DkeFi+l8R7UZuovHc6lHcuVwNIPkfyQ7CWCBuIt4sT6TyEsaNMbR7qpWyPTbLRJAJ+UHc34D69uZw6A6qB8lv71WaoRuy6Rg4el3C++9C+cSfGiFINRGsSYe5Bm4zln7zX/CgRTBufhPF/wQdppcA1k8LcXrRkLsFC4gjo55/mFKZZ+kR2otM0xp0JUYMMoAoEWmaiF2qtYdZjghIrx0rW6YyVU8EBTGWBqm5QWPxcvjtTwELIGTWe1VgYJWIkImxTMMyND/3kZoGWzfCaMFlPKYw7LVsyW+h2nILh2/Ct3BZ8OF33hxCEAYWom1gXKn9mZiGhH04/tyvxPwtBsKFK2Y/RXqfqCuB2qztUGQ56sFpCsPwUMQ3P+VOSsx9nrP+z+BGFaBisjI= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2017 10:49:53.1942 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR03MB477 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-07-14 at 09:48 +0100, Srinivas Kandagatla wrote: > On 12/07/17 07:36, Shawn Guo wrote: > > > +static int nvmem_cell_read_u32(struct device* dev, const char *cell_id, u32 *val) > > > +{ > > > + struct nvmem_cell *cell; > > > + void *buf; > > > + size_t len; > > > + > > > + cell = nvmem_cell_get(dev, cell_id); > > > + if (IS_ERR(cell)) > > > + return PTR_ERR(cell); > > > + > > > + buf = nvmem_cell_read(cell, &len); > > > + if (IS_ERR(buf)) { > > > + nvmem_cell_put(cell); > > > + return PTR_ERR(buf); > > > + } > > > + if (len != sizeof(*val)) { > > > + kfree(buf); > > > + nvmem_cell_put(cell); > > > + return -EINVAL; > > > + } > > > + memcpy(val, buf, sizeof(*val)); > This can overflow the memory allocated to val, we should be careful here  > not to do so. > limit this to sizeof(u32) should be good. Also add some sanity checks to  > make sure that len is atleast 4 bytes. I'm not sure what you mean, isn't this already done? There is an explicit check above that the read len is exactly as expected. It's just that the limit is written as sizeof(*val) rather than sizeof(u32). > > > + > > > + kfree(buf); > > > + nvmem_cell_put(cell); > > > + return 0; > > > +} > > The function looks nothing IMX specific, and could be a nvmem core > > function? > > > > @Srinivas, thoughts? > Yep, this function looks generic, can be moved to nvmem layer. Ok, next version of the series will have this function in nvmem core as a separate commit.