From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932077AbdGNNmP convert rfc822-to-8bit (ORCPT ); Fri, 14 Jul 2017 09:42:15 -0400 Received: from mout.gmx.net ([212.227.17.22]:54582 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753635AbdGNNmN (ORCPT ); Fri, 14 Jul 2017 09:42:13 -0400 Message-ID: <1500039693.5763.15.camel@gmx.de> Subject: Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 From: Mike Galbraith To: Ilia Mirkin , Peter Zijlstra Cc: LKML , "dri-devel@lists.freedesktop.org" , "nouveau@lists.freedesktop.org" , David Airlie , Ben Skeggs Date: Fri, 14 Jul 2017 15:41:33 +0200 In-Reply-To: <1500039368.5763.12.camel@gmx.de> References: <1499794333.5315.8.camel@gmx.de> <1499796510.5315.27.camel@gmx.de> <1499853345.23742.8.camel@gmx.de> <1499858703.23742.25.camel@gmx.de> <1500039368.5763.12.camel@gmx.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K0:98vyqHFBTB0GvLxCxDMhXTXdOsTdh6fBREL7aZwus0mTYsxVd3Y OgA+FDKUwCh0twZ6VPdA/YW25cve4YtGh/3v0riSbI42rznYP5yFKkdEpFPpEiKJXvsigAB yz7K0a89OFAW3WN6tvqIkVz6umFCWP92Xkqc1crCK7bXK7H6XF+mL1TvwuKA0YzVaG4nH/q Nda2AKeF/mU1oUn7MQZaw== X-UI-Out-Filterresults: notjunk:1;V01:K0:xM1R4ir9HqA=:57w/bwVZJ6l54F3/6BEbHt FY/IRAPGbuhpssc72s945lS+ztCEh97d2Q9vVX8Wv5c36ZPu3GPovZvyeDyZFFjI3VKzxewrQ TfqwCaS7bXOJEgwXetteVJHMfwZj6Hs5xPd+BdBCXzo9855ZicTTaUcDy2tzLAomyaFFgH7kI nFMRdJS4rouNfjJwnD48T0SNaRBfi1l1tdwEMPOG5W7b3DOCd23XCF1ri2UVZRS2PGaLrvL2m NSGMMBDM9R2PO0342LevRjaKRnugI395n8l8kerv7sOFwB2pkArCfKBdWR7LjBuCNNkpyt/16 ZVUnBzCr7zYX38kpkBcQbUzB3yEm047E6FaC4xCREEqVRL6j19diJvMxxMKTUPtaHrSCDJO32 d2gaRVnbg5ZT8m6KWYTMvIf1gzT5sg8mHy0vwSYzJFEXEx2M/Z9jhcIPuLXlHLOcH+RDkJJN8 KoSvOiSOn7a1IVyk234uE5hqIBWM8pqHQae2GDCdGcfF3+GT7WndVb7rbM9M+3ByL7l77Dap6 Q1dyZg3LFrBkcAXLZfPEYlC0PGqBf+0qMZLrvLdE4WeikM1D8XkX3FiuSwzbnyXOPY6FD2nGH tUMy4Lu0RBckUfEttT+YUBQ+3liuX5K1BmYynG+QUzCN5kAJFWkJXn8UlKA3M/BfhAxg98T5a gBM9CcV6VAj+/LbF2++BluYcSNuIkdOQY6Yt+1zxgeq+pf07h9I2iI0zBQssJ9QQJICmGmaI+ g4cf+WS+0PeWICFYgTZ4YOYaN8tLpKyUnPAj3CIQKFttFLiGAYtt5ZwYnDAbltiTfz1nOR7mg WioOaKpDKd7XHhqJ6RCpdkX+nWcB4DbOs6pG/Y+F9gMJXs81no= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-07-14 at 15:36 +0200, Mike Galbraith wrote: >  All DRM did was to slip a > WARN_ON_ONCE() that nouveau triggers into a kernel module where such > things no longer warn, they blow the box out of the water. BTW, turn that irksome WARN_ON_ONCE() in drivers/gpu/drm/drm_vblank.c into a WARN_ONCE(), and all is peachy, you get the warning, box lives. --- drivers/gpu/drm/drm_vblank.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/drm_vblank.c +++ b/drivers/gpu/drm/drm_vblank.c @@ -605,7 +605,8 @@ bool drm_calc_vbltimestamp_from_scanoutp */ if (mode->crtc_clock == 0) { DRM_DEBUG("crtc %u: Noop due to uninitialized mode.\n", pipe); - WARN_ON_ONCE(drm_drv_uses_atomic_modeset(dev)); + WARN_ONCE(drm_drv_uses_atomic_modeset(dev), "%s: report me.\n", + dev->driver->name); return false; }