From: Pierre Kuo <vichy.kuo@gmail.com>
To: pmladek@suse.com
Cc: sergey.senozhatsky@gmail.com, rostedt@goodmis.org,
linux-kernel@vger.kernel.org, joe@perches.com,
pierre Kuo <vichy.kuo@gmail.com>
Subject: [PATCH] printk: modify console_unlock with printk-safe macros
Date: Sat, 15 Jul 2017 18:36:54 +0800 [thread overview]
Message-ID: <1500115014-3420-1-git-send-email-vichy.kuo@gmail.com> (raw)
From: pierre Kuo <vichy.kuo@gmail.com>
In commit de6fcbdb68b2 ("printk: convert the rest to printk-safe"), we
create 4 helper macros to make printk-safe usage easier.
Here we modify some part of console_unlock with above marcros.
Signed-off-by: Pierre Kuo <vichy.kuo@gmail.com>
---
kernel/printk/printk.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index fc47863..21557cc 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2194,8 +2194,7 @@ void console_unlock(void)
size_t ext_len = 0;
size_t len;
- printk_safe_enter_irqsave(flags);
- raw_spin_lock(&logbuf_lock);
+ logbuf_lock_irqsave(flags);
if (seen_seq != log_next_seq) {
wake_klogd = true;
seen_seq = log_next_seq;
@@ -2267,8 +2266,7 @@ void console_unlock(void)
*/
raw_spin_lock(&logbuf_lock);
retry = console_seq != log_next_seq;
- raw_spin_unlock(&logbuf_lock);
- printk_safe_exit_irqrestore(flags);
+ logbuf_unlock_irqrestore(flags);
if (retry && console_trylock())
goto again;
--
1.7.9.5
next reply other threads:[~2017-07-15 10:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 10:36 Pierre Kuo [this message]
2017-07-15 12:36 ` [PATCH] printk: modify console_unlock with printk-safe macros Andy Shevchenko
2017-07-17 9:28 ` Sergey Senozhatsky
2017-07-17 11:06 ` pierre kuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500115014-3420-1-git-send-email-vichy.kuo@gmail.com \
--to=vichy.kuo@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox