From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 3/3] fat: fix quoted string splits
Date: Sun, 16 Jul 2017 08:06:48 -0700 [thread overview]
Message-ID: <1500217608.4457.88.camel@perches.com> (raw)
In-Reply-To: <CAHp75VdpV2AbaxL9A5=frD0P-fMxZgRbGg=VTfEypzeDodp=NA@mail.gmail.com>
On Sun, 2017-07-16 at 16:46 +0300, Andy Shevchenko wrote:
> On Sat, Jul 15, 2017 at 7:18 AM, Joe Perches <joe@perches.com> wrote:
> > On Sat, 2017-07-15 at 04:20 +0300, Andy Shevchenko wrote:
> > > On Sat, Jul 15, 2017 at 2:05 AM, Carlos Palminha
> > > <CARLOS.PALMINHA@synopsys.com> wrote:
> > > > corrects quoted string split across lines, based on checkpatch.
> > >
> > > At some point you may switch
> > >
> > > fat_msg(sb, KERN_ERR, ...)
> > >
> > > to
> > >
> > > fat_fs_error(sb, ...)
> >
> > The output would be different.
>
> As much as it adds 'error, ' at the beginning of message. I can't
> consider this a bad idea.
Adding "error" to KERN_ERR output is unnecessary
and if really desired, should be done by dmesg
or equivalent.
next prev parent reply other threads:[~2017-07-16 15:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 23:05 [PATCH 0/3] fat: fix several checkpatch warnings Carlos Palminha
2017-07-14 23:05 ` [PATCH 1/3] fat: remove prohibited spaces Carlos Palminha
2017-07-14 23:05 ` [PATCH 2/3] fat: add missing blank lines Carlos Palminha
2017-07-14 23:05 ` [PATCH 3/3] fat: fix quoted string splits Carlos Palminha
2017-07-15 1:20 ` Andy Shevchenko
2017-07-15 4:18 ` Joe Perches
2017-07-16 13:46 ` Andy Shevchenko
2017-07-16 15:06 ` Joe Perches [this message]
2017-07-16 15:30 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500217608.4457.88.camel@perches.com \
--to=joe@perches.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=andy.shevchenko@gmail.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox