From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751418AbdGPPGx (ORCPT <rfc822;w@1wt.eu>);
        Sun, 16 Jul 2017 11:06:53 -0400
Received: from smtprelay0081.hostedemail.com ([216.40.44.81]:55394 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751216AbdGPPGw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 16 Jul 2017 11:06:52 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3873:4321:5007:7903:10004:10400:10848:11026:11232:11658:11914:12043:12296:12740:12760:12895:13069:13095:13311:13357:13439:14096:14097:14181:14659:14721:21080:21433:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: year96_58c47e9406538
X-Filterd-Recvd-Size: 1914
Message-ID: <1500217608.4457.88.camel@perches.com>
Subject: Re: [PATCH 3/3] fat: fix quoted string splits
From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
        Alexander Viro <viro@zeniv.linux.org.uk>
Date: Sun, 16 Jul 2017 08:06:48 -0700
In-Reply-To: <CAHp75VdpV2AbaxL9A5=frD0P-fMxZgRbGg=VTfEypzeDodp=NA@mail.gmail.com>
References: <20170714230550.9435-1-palminha@synopsys.com>
         <20170714230550.9435-4-palminha@synopsys.com>
         <CAHp75Vfqee0edyJ0SOTN9vZE7KTDv6ZKiZomn9aUHm90sfuekQ@mail.gmail.com>
         <1500092280.4457.77.camel@perches.com>
         <CAHp75VdpV2AbaxL9A5=frD0P-fMxZgRbGg=VTfEypzeDodp=NA@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.6-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2017-07-16 at 16:46 +0300, Andy Shevchenko wrote:
> On Sat, Jul 15, 2017 at 7:18 AM, Joe Perches <joe@perches.com> wrote:
> > On Sat, 2017-07-15 at 04:20 +0300, Andy Shevchenko wrote:
> > > On Sat, Jul 15, 2017 at 2:05 AM, Carlos Palminha
> > > <CARLOS.PALMINHA@synopsys.com> wrote:
> > > > corrects quoted string split across lines, based on checkpatch.
> > > 
> > > At some point you may switch
> > > 
> > > fat_msg(sb, KERN_ERR, ...)
> > > 
> > > to
> > > 
> > > fat_fs_error(sb, ...)
> > 
> > The output would be different.
> 
> As much as it adds 'error, ' at the beginning of message. I can't
> consider this a bad idea.

Adding "error" to KERN_ERR output is unnecessary
and if really desired, should be done by dmesg
or equivalent.