From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751313AbdGPPL0 (ORCPT ); Sun, 16 Jul 2017 11:11:26 -0400 Received: from smtprelay0040.hostedemail.com ([216.40.44.40]:55848 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751131AbdGPPLY (ORCPT ); Sun, 16 Jul 2017 11:11:24 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3870:3872:4250:4321:5007:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12048:12740:12760:12895:13019:13069:13311:13357:13439:14659:21080:21433:21451:21627:30012:30046:30054:30075:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: hot93_8057c3c3abf58 X-Filterd-Recvd-Size: 1549 Message-ID: <1500217880.4457.90.camel@perches.com> Subject: Re: [PATCH] i40iw: Simplify code From: Joe Perches To: Christophe JAILLET , faisal.latif@intel.com, shiraz.saleem@intel.com, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Sun, 16 Jul 2017 08:11:20 -0700 In-Reply-To: <20170716110923.14907-1-christophe.jaillet@wanadoo.fr> References: <20170716110923.14907-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-07-16 at 13:09 +0200, Christophe JAILLET wrote: > Axe a few lines of code and re-use existing error handling path to avoid > code duplication. unrelated: > diff --git a/drivers/infiniband/hw/i40iw/i40iw_pble.c b/drivers/infiniband/hw/i40iw/i40iw_pble.c [] > @@ -280,8 +278,7 @@ static enum i40iw_status_code add_bp_pages(struct i40iw_sc_dev *dev, > (info->pages << PBLE_512_SHIFT)); > if (status) { > i40iw_pr_err("allocate PBLEs in the PF. Error %i\n", status); It'd be nice if i40iw_pr_ were removed and converted into dev_ or netdev_.