From: Joe Perches <joe@perches.com>
To: Shy More <smklearn@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Kosina <trivial@kernel.org>, Alan Cox <alan@linux.intel.com>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] [media] staging/atomisp: fixed trivial coding style issue
Date: Sun, 16 Jul 2017 16:57:20 -0700 [thread overview]
Message-ID: <1500249440.4457.95.camel@perches.com> (raw)
In-Reply-To: <1500248306-15155-1-git-send-email-smklearn@gmail.com>
On Sun, 2017-07-16 at 16:38 -0700, Shy More wrote:
> Below was the trival error flagged by checkpatch.pl:
> ERROR: space prohibited after that open parenthesis '('
[]
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
[]
> @@ -131,7 +131,7 @@ void ia_css_isys_ibuf_rmgr_release(
> for (i = 0; i < ibuf_rsrc.num_allocated; i++) {
> handle = getHandle(i);
> if ((handle->start_addr == *start_addr)
> - && ( true == handle->active)) {
> + && (true == handle->active)) {
> handle->active = false;
> ibuf_rsrc.num_active--;
> break;
Better would have been to remove the comparison to true
if (handle->start_addr == *start_addr && handle->active)
but this would probably read better and perhaps be
marginally faster on some processors if written like:
if (handle->active && handle->start_addr == *start_addr)
next prev parent reply other threads:[~2017-07-16 23:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 15:06 [PATCH] [media] staging/atomisp: fix minor coding style warnings smklearn
2017-07-13 15:12 ` Greg KH
2017-07-16 23:35 ` [PATCH 1/2] [media] staging/atomisp: fixed trivial coding style warning Shy More
2017-07-16 23:38 ` [PATCH 2/2] [media] staging/atomisp: fixed trivial coding style issue Shy More
2017-07-16 23:57 ` Joe Perches [this message]
2017-07-17 4:10 ` [PATCH v2] " Shy More
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500249440.4457.95.camel@perches.com \
--to=joe@perches.com \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=smklearn@gmail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox