From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751263AbdGPX5Z (ORCPT ); Sun, 16 Jul 2017 19:57:25 -0400 Received: from smtprelay0074.hostedemail.com ([216.40.44.74]:35510 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751124AbdGPX5Y (ORCPT ); Sun, 16 Jul 2017 19:57:24 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3874:4321:5007:6119:6609:7903:10004:10400:10848:11026:11232:11657:11658:11914:12043:12295:12438:12740:12895:13069:13311:13357:13439:13894:14181:14659:14721:21080:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: stew67_4056ea9a55324 X-Filterd-Recvd-Size: 2007 Message-ID: <1500249440.4457.95.camel@perches.com> Subject: Re: [PATCH 2/2] [media] staging/atomisp: fixed trivial coding style issue From: Joe Perches To: Shy More Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , Jiri Kosina , Alan Cox , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sun, 16 Jul 2017 16:57:20 -0700 In-Reply-To: <1500248306-15155-1-git-send-email-smklearn@gmail.com> References: <20170713151249.GA1451@kroah.com> <1500248306-15155-1-git-send-email-smklearn@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-07-16 at 16:38 -0700, Shy More wrote: > Below was the trival error flagged by checkpatch.pl: > ERROR: space prohibited after that open parenthesis '(' [] > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c [] > @@ -131,7 +131,7 @@ void ia_css_isys_ibuf_rmgr_release( > for (i = 0; i < ibuf_rsrc.num_allocated; i++) { > handle = getHandle(i); > if ((handle->start_addr == *start_addr) > - && ( true == handle->active)) { > + && (true == handle->active)) { > handle->active = false; > ibuf_rsrc.num_active--; > break; Better would have been to remove the comparison to true if (handle->start_addr == *start_addr && handle->active) but this would probably read better and perhaps be marginally faster on some processors if written like: if (handle->active && handle->start_addr == *start_addr)