public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jin Yao <yao.jin@linux.intel.com>
To: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com,
	mpe@ellerman.id.au
Cc: Linux-kernel@vger.kernel.org, ak@linux.intel.com,
	kan.liang@intel.com, yao.jin@intel.com,
	Jin Yao <yao.jin@linux.intel.com>
Subject: [PATCH v9 0/7] perf report: Show branch type
Date: Mon, 17 Jul 2017 19:06:36 +0800	[thread overview]
Message-ID: <1500289603-4352-1-git-send-email-yao.jin@linux.intel.com> (raw)

v9:
---
   It only changes the patch "perf/x86/intel: Record branch type".
   Peter suggests to use __ffs() to find first bit.
   Yes, with this change, the code is simpler and clearer.

   No other functional changes.


v8:
---
   Change PERF_BR_NONE to PERF_BR_UNKNOWN according to Peter's comments.
   No other functional changes.


v7:
---
   Redefine the common branch types according to review comments from
   Michael Ellerman <mpe@ellerman.id.au>

   Now the patch series just defines a minimum but more common set of
   branch types.

   PERF_BR_NONE            : unknown
   PERF_BR_COND            :conditional
   PERF_BR_UNCOND          : unconditional
   PERF_BR_IND             : indirect
   PERF_BR_CALL            : function call
   PERF_BR_IND_CALL        : indirect function call
   PERF_BR_RET             : function return
   PERF_BR_SYSCALL         : syscall
   PERF_BR_SYSRET          : syscall return
   PERF_BR_COND_CALL       : conditional function call
   PERF_BR_COND_RET        : conditional function return


v6:
---
   Update according to the review comments from
   Jiri Olsa <jolsa@redhat.com>. Major modifications are:

   1. Move that multiline conditional code inside {} brackets.

   2. Move branch_type_stat_display() from builtin-report.c to
      branch.c. Move branch_type_str() from callchain.c to
      branch.c.

   3. Keep the original branch info display order, that is:
      predicted, abort, cycles, iterations


v5:
---
   Mainly the v5 patch series are updated according to
   comments from Jiri Olsa <jolsa@redhat.com>.

   The kernel part doesn't have functional change. It just
   solve the merge issue.

   In userspace, the functions of branch type counting and
   branch type name resolving are moved to the new files:
   util/branch.c, util/branch.h.

   And refactor the branch info printing code for better
   maintenance.

Not changed (or just fix merge issue):
  perf/core: Define the common branch type classification
  perf/x86/intel: Record branch type
  perf record: Create a new option save_type in --branch-filter

New patches:
  perf report: Refactor the branch info printing code
  perf util: Create branch.c/.h for common branch functions

Changed:
  perf report: Show branch type statistics for stdio mode
  perf report: Show branch type in callchain entry


v4:
---
1. Describe the major changes in patch description.
   Thanks for Peter Zijlstra's reminding.

2. Initialize branch type to 0 in intel_pmu_lbr_read_32 and
   intel_pmu_lbr_read_64. Remove the invalid else code in
   intel_pmu_lbr_filter.


v3:
---
1. Move the JCC forward/backward and cross page computing from
   kernel to userspace.

2. Use lookup table to replace original switch/case processing.


Changed:
  perf/core: Define the common branch type classification
  perf/x86/intel: Record branch type
  perf report: Show branch type statistics for stdio mode
  perf report: Show branch type in callchain entry

Not changed:
  perf record: Create a new option save_type in --branch-filter

v2:
---
1. Use 4 bits in perf_branch_entry to record branch type.

2. Pull out some common branch types from FAR_BRANCH. Now the branch
   types defined in perf_event.h:

Jin Yao (7):
  perf/core: Define the common branch type classification
  perf/x86/intel: Record branch type
  perf record: Create a new option save_type in --branch-filter
  perf report: Refactor the branch info printing code
  perf util: Create branch.c/.h for common branch functions
  perf report: Show branch type statistics for stdio mode
  perf report: Show branch type in callchain entry

 arch/x86/events/intel/lbr.c              |  51 +++++++++-
 include/uapi/linux/perf_event.h          |  27 ++++-
 tools/include/uapi/linux/perf_event.h    |  27 ++++-
 tools/perf/Documentation/perf-record.txt |   1 +
 tools/perf/builtin-report.c              |  25 +++++
 tools/perf/util/Build                    |   1 +
 tools/perf/util/branch.c                 | 166 +++++++++++++++++++++++++++++++
 tools/perf/util/branch.h                 |  25 +++++
 tools/perf/util/callchain.c              | 140 ++++++++++++++------------
 tools/perf/util/callchain.h              |   5 +-
 tools/perf/util/event.h                  |   3 +-
 tools/perf/util/hist.c                   |   5 +-
 tools/perf/util/machine.c                |  26 +++--
 tools/perf/util/parse-branch-options.c   |   1 +
 14 files changed, 419 insertions(+), 84 deletions(-)
 create mode 100644 tools/perf/util/branch.c
 create mode 100644 tools/perf/util/branch.h

-- 
2.7.4

             reply	other threads:[~2017-07-17  3:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 11:06 Jin Yao [this message]
2017-07-17  8:19 ` [PATCH v9 0/7] perf report: Show branch type Jiri Olsa
2017-07-17 11:06 ` [PATCH v9 1/7] perf/core: Define the common branch type classification Jin Yao
2017-07-17 11:06 ` [PATCH v9 2/7] perf/x86/intel: Record branch type Jin Yao
2017-07-17  8:11   ` Jiri Olsa
2017-07-17  8:28     ` Jin, Yao
2017-07-18  9:23       ` Peter Zijlstra
2017-07-17 11:06 ` [PATCH v9 3/7] perf record: Create a new option save_type in --branch-filter Jin Yao
2017-07-17 11:06 ` [PATCH v9 4/7] perf report: Refactor the branch info printing code Jin Yao
2017-07-17 11:06 ` [PATCH v9 5/7] perf util: Create branch.c/.h for common branch functions Jin Yao
2017-07-17 11:06 ` [PATCH v9 6/7] perf report: Show branch type statistics for stdio mode Jin Yao
2017-07-17 11:06 ` [PATCH v9 7/7] perf report: Show branch type in callchain entry Jin Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500289603-4352-1-git-send-email-yao.jin@linux.intel.com \
    --to=yao.jin@linux.intel.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox