From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751330AbdGQNXI (ORCPT ); Mon, 17 Jul 2017 09:23:08 -0400 Received: from mga02.intel.com ([134.134.136.20]:48867 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281AbdGQNXH (ORCPT ); Mon, 17 Jul 2017 09:23:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,374,1496127600"; d="scan'208";a="1152331213" Message-ID: <1500297783.29303.42.camel@linux.intel.com> Subject: Re: [PATCH 2/2] mfd: intel_soc_pmic: Differentiate between Bay and Cherry Trail CRC variants From: Andy Shevchenko To: Lee Jones , Hans de Goede Cc: Jarkko Nikula , Len Brown , Mika Westerberg , linux-kernel@vger.kernel.org Date: Mon, 17 Jul 2017 16:23:03 +0300 In-Reply-To: <20170717105904.iguqoroc5o74hj4f@dell> References: <20170701101346.13578-1-hdegoede@redhat.com> <20170701101346.13578-2-hdegoede@redhat.com> <20170717105904.iguqoroc5o74hj4f@dell> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-07-17 at 11:59 +0100, Lee Jones wrote: > On Sat, 01 Jul 2017, Hans de Goede wrote: > > > Both Bay and Cherry Trail devices may be used together with a > > Crystal Cove > > PMIC. Each platform has its own variant of the PMIC, which both use > > the > > same ACPI HID, but they are not 100% compatible. > > > > This commits makes the intel_soc_pmic_core code check the _HRV of > > the > > ACPI-firmware-node and selects intel_soc_pmic_config_byt_crc resp. > > intel_soc_pmic_config_cht_crc based on this. > > > > This fixes the Bay Trail specific ACPI OpRegion code causing > > problems > > on Cherry Trail devices. Specifically this was causing the external > > microsd slot on a Dell Venue 8 5855 (Cherry Trail version) to not > > work > > and the eMMC to become unreliable and throw lots of errors. > > > > Reported-and-tested-by: russianneuromancer > > > > Real names only please. > > What is the name of this reporter/tester? No one knows, I think. -- Andy Shevchenko Intel Finland Oy