Re: [PATCH 1/3] ACPI / blacklist: add acpi_match_oemlist() interface

["Kani, Toshimitsu" <toshi.kani@hpe.com>]

On Tue, 2017-07-18 at 07:34 +0200, Borislav Petkov wrote:
> On Mon, Jul 17, 2017 at 03:59:10PM -0600, Toshi Kani wrote:
> > ACPI OEM ID / OEM Table ID / Revision can be used to identify
> > platform type based on ACPI firmware.  acpi_blacklisted(),
> > intel_pstate_platform_pwr_mgmt_exists() and some other funcs
> > have been using this type of check to detect a list of platforms
> > that require special handlings.
> > 
> > Move the platform type check in acpi_blacklisted() to a common
> > utility function, acpi_match_oemlist(), so that other drivers
> > do not have to implement their own.
> > 
> > There is no change in functionality.
 :
> >  /*
> >   * POLICY: If *anything* doesn't work, put it on the blacklist.
> >   *	   If they are critical errors, mark it critical, and
> > abort driver load.
> >   */
> > -static struct acpi_blacklist_item acpi_blacklist[] __initdata = {
> > +static struct acpi_oemlist acpi_blacklist[] __initdata = {
> 
> Why the arbitrary rename?

This patch defines 'struct acpi_oemlist' in "include/linux/acpi.h" as a
common structure, and replaces this specific 'struct acpi_blacklist'.

> If anything, you should shorten that
> 
> 	enum acpi_blacklist_predicates oem_revision_predicate;
> 
> unreadable insanity.

Agreed.  Will change to a shorter name like below. 

	enum acpi_oemlist_pred predicate;

+	i = acpi_match_oemlist(acpi_blacklist);
> > +	if (i >= 0) {
> > +		pr_err(PREFIX "Vendor \"%6.6s\" System \"%8.8s\" "
> > +		       "Revision 0x%x has a known ACPI BIOS
> > problem.\n",
> 
> Put that string on a single line for grepping. checkpatch catches
> that error, didn't you see it?

Will do.

Thanks!
-Toshi