From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751503AbdGRRll (ORCPT ); Tue, 18 Jul 2017 13:41:41 -0400 Received: from smtprelay0116.hostedemail.com ([216.40.44.116]:52643 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751379AbdGRRlk (ORCPT ); Tue, 18 Jul 2017 13:41:40 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:2896:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:4250:4321:5007:6119:7903:10004:10400:10848:11026:11232:11473:11658:11914:12050:12296:12438:12740:12760:12895:13069:13141:13230:13311:13357:13439:14659:14721:21080:21212:21434:21451:21627:30012:30051:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: bite96_6571a70ede418 X-Filterd-Recvd-Size: 1941 Message-ID: <1500399695.25934.25.camel@perches.com> Subject: Re: [PATCH 1/4] rtc-lib: Add rtc_show_time(const char *prefix_msg) From: Joe Perches To: Mark Salyzyn , linux-kernel@vger.kernel.org Cc: rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz, linux-pm@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, linux-rtc@vger.kernel.org Date: Tue, 18 Jul 2017 10:41:35 -0700 In-Reply-To: <20170718172525.114514-1-salyzyn@android.com> References: <20170718172525.114514-1-salyzyn@android.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-07-18 at 10:25 -0700, Mark Salyzyn wrote: > Go directly to the rtc for persistent wall clock time and print. > Useful if REALTIME is required to be logged in a low level power > management function or when clock activities are suspended. An > aid to permit user space alignment of kernel activities. [] > diff --git a/include/linux/rtc.h b/include/linux/rtc.h [] > @@ -22,6 +22,11 @@ extern int rtc_year_days(unsigned int day, unsigned int month, unsigned int year > extern int rtc_valid_tm(struct rtc_time *tm); > extern time64_t rtc_tm_to_time64(struct rtc_time *tm); > extern void rtc_time64_to_tm(time64_t time, struct rtc_time *tm); > +#ifdef CONFIG_RTC_SHOW_TIME > +extern void rtc_show_time(const char *prefix_msg); > +#else > +#define rtc_show_time(prefix_msg) It's generally better to use a static inline to avoid misuses in newly added code in the !CONFIG_RTC_SHOW_TIME compile path when CONFIG_RTC_SHOW_TIME may not be compiled. static inline void rtc_show_time(const char *prefix_msg) { }