From: Kiran Gunda <kgunda@codeaurora.org>
To: gregkh@linuxfoundation.org, sboyd@codeaurora.org,
Kiran Gunda <kgunda@codeaurora.org>,
Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
David Collins <collinsd@codeaurora.org>,
linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org
Subject: [PATCH V1 08/12] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability
Date: Thu, 20 Jul 2017 13:01:46 +0530 [thread overview]
Message-ID: <1500535910-28705-9-git-send-email-kgunda@codeaurora.org> (raw)
In-Reply-To: <1500535910-28705-1-git-send-email-kgunda@codeaurora.org>
Currently the driver sets the pmic arbiter core interrupt as wakeup capable
irrespective of the child irqs which causes the system to wakeup
unnecessarily. To fix this, set the core interrupt as wakeup capable
only if any of the child irqs request for it. Do this by marking it as
wakeup capable in the irq_set_wake callback.
Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/spmi/spmi-pmic-arb.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index fed2883a..e8c08c0 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -622,6 +622,13 @@ static int qpnpint_irq_set_type(struct irq_data *d, unsigned int flow_type)
return 0;
}
+static int qpnpint_irq_set_wake(struct irq_data *d, unsigned int on)
+{
+ struct spmi_pmic_arb *pmic_arb = irq_data_get_irq_chip_data(d);
+
+ return irq_set_irq_wake(pmic_arb->irq, on);
+}
+
static int qpnpint_get_irqchip_state(struct irq_data *d,
enum irqchip_irq_state which,
bool *state)
@@ -644,9 +651,9 @@ static int qpnpint_get_irqchip_state(struct irq_data *d,
.irq_mask = qpnpint_irq_mask,
.irq_unmask = qpnpint_irq_unmask,
.irq_set_type = qpnpint_irq_set_type,
+ .irq_set_wake = qpnpint_irq_set_wake,
.irq_get_irqchip_state = qpnpint_get_irqchip_state,
- .flags = IRQCHIP_MASK_ON_SUSPEND
- | IRQCHIP_SKIP_SET_WAKE,
+ .flags = IRQCHIP_MASK_ON_SUSPEND,
};
static int qpnpint_irq_domain_dt_translate(struct irq_domain *d,
@@ -1068,8 +1075,6 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev)
irq_set_chained_handler_and_data(pmic_arb->irq, pmic_arb_chained_irq,
pmic_arb);
- enable_irq_wake(pmic_arb->irq);
-
err = spmi_controller_add(ctrl);
if (err)
goto err_domain_remove;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-07-20 7:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 7:31 [PATCH V1 00/12]: spmi: pmic-arb: Support for HW v5 and other fixes Kiran Gunda
2017-07-20 7:31 ` [PATCH V1 01/12] spmi: pmic-arb: remove the read/write access checks Kiran Gunda
2017-07-20 7:31 ` [PATCH V1 02/12] spmi: pmic-arb: rename pa_xx to pmic_arb_xx and other cleanup Kiran Gunda
2017-07-28 0:00 ` Stephen Boyd
2017-07-28 5:54 ` kgunda
2017-07-20 7:31 ` [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid function Kiran Gunda
2017-07-28 1:18 ` Stephen Boyd
2017-07-28 5:33 ` kgunda
2017-07-20 7:31 ` [PATCH V1 04/12] spmi: pmic-arb: optimize qpnpint_irq_set_type function Kiran Gunda
2017-07-27 23:46 ` Stephen Boyd
2017-07-20 7:31 ` [PATCH V1 05/12] spmi: pmic-arb: fix memory allocation for mapping_table Kiran Gunda
2017-07-27 23:49 ` Stephen Boyd
2017-07-28 0:01 ` Stephen Boyd
2017-07-28 5:32 ` kgunda
2017-07-20 7:31 ` [PATCH V1 06/12] spmi: pmic-arb: replace the writel_relaxed with __raw_writel Kiran Gunda
2017-07-28 0:01 ` Stephen Boyd
2017-07-28 5:34 ` kgunda
2017-07-20 7:31 ` [PATCH V1 07/12] spmi: pmic-arb: return the value instead of passing by pointer Kiran Gunda
2017-07-20 7:31 ` Kiran Gunda [this message]
2017-07-20 7:31 ` [PATCH V1 09/12] spmi: pmic-arb: return __iomem pointer instead of offset Kiran Gunda
2017-07-20 7:31 ` [PATCH V1 10/12] spmi: pmic-arb: fix a possible null pointer dereference Kiran Gunda
2017-07-20 7:31 ` [PATCH V1 11/12] spmi: pmic-arb: add support for HW version 5 Kiran Gunda
2017-07-20 7:31 ` [PATCH V1 12/12] spmi: pmic-arb: Remove checking opc value not less than 0 Kiran Gunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500535910-28705-9-git-send-email-kgunda@codeaurora.org \
--to=kgunda@codeaurora.org \
--cc=adharmap@codeaurora.org \
--cc=collinsd@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).