From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH Y.A. RESEND] MAINTAINERS: fix alpha. ordering
Date: Sun, 23 Jul 2017 13:05:30 -0700 [thread overview]
Message-ID: <1500840330.23924.1.camel@perches.com> (raw)
In-Reply-To: <CA+55aFy3naVgbRubhjfq7k4CcSiFOEdQNkNwHTLDLmepECu9yA@mail.gmail.com>
On Sun, 2017-07-23 at 12:49 -0700, Linus Torvalds wrote:
> Ok, so I already applied your alpha-ordering patch, but it just annoyed me that
>
> (a) the ordering wasn't complete
>
> (b) this wasn't scripted.
>
> However, the sane way of scripting it is clearly not to do it in C,
> which I'd be comfy with, because that would be insane.
>
> Instead, it should be done in perl. Except my perl-fu is so horribly
> horribly bad that I'm a bit ashamed to show the end result.
>
> Does anybody have actual real perl skills? Because somebody should
> double-check my appended script-from-hell.
>
> ANYWAY. One reason I did this was because *if* we want to split up the
> MAINTAINERS file, I absolutely refuse to do it by hand. It needs to be
> automated. I'm not going to apply a patch - I'm going to apply a
> *script*, and commit the end result along with the doc about what the
> script was (so that then I have an inevitable conflict due to this big
> re-org, I can resolve the conflict by re-running the script on the
> side that wasn't part of the re-org, rather than having to do nasty
> things).
>
> And this script could easily be extended to automate the scripting. So
> please, can somebody with perl-fu say that "yeah, that's the right
> perl model", or point me to what I did wrong?
>
> The end result looks ok. I can run
>
> perl parse-maintainers.pl < MAINTAINERS > outfile
>
> and the end result is actually a *properly* sorted MAINTAINERS file as
> far as I can tell.
>
> Comments?
That works OK except for this section
where there are 2 header lines
EDAC-XGENE
APPLIED MICRO (APM) X-GENE SOC EDAC
M: Loc Ho <lho@apm.com>
S: Supported
F: drivers/edac/xgene_edac.c
F: Documentation/devicetree/bindings/edac/apm-xgene-edac.txt
If you take up the patch I sent for that
before you run the script, it should be OK.
https://patchwork.kernel.org/patch/9857337/
I'll send a get_maintainers patch that allows a few
different styles of MAINTAINERS files separately.
o A single top level MAINTAINERS file
o A MAINTAINERS directory with multiple section files
o MAINTAINERS files distributed around the kernel source tree
prev parent reply other threads:[~2017-07-23 20:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 20:32 [PATCH Y.A. RESEND] MAINTAINERS: fix alpha. ordering Randy Dunlap
2017-07-22 2:01 ` Linus Torvalds
2017-07-23 19:49 ` Linus Torvalds
2017-07-23 20:00 ` Linus Torvalds
2017-07-23 20:10 ` Joe Perches
2017-07-23 23:14 ` Linus Torvalds
2017-07-24 1:38 ` Joe Perches
2017-07-28 0:30 ` Joe Perches
2017-07-28 2:43 ` Linus Torvalds
2017-07-28 3:12 ` Joe Perches
2017-07-28 22:30 ` Linus Torvalds
2017-07-29 1:08 ` Joe Perches
2017-07-29 17:46 ` Joe Perches
2017-07-23 20:05 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500840330.23924.1.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox