From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753725AbdGXKx3 (ORCPT ); Mon, 24 Jul 2017 06:53:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:47106 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752259AbdGXKxV (ORCPT ); Mon, 24 Jul 2017 06:53:21 -0400 Message-ID: <1500893441.16387.2.camel@suse.com> Subject: Re: [PATCH v6] Bluetooth: btusb: Fix memory leak in play_deferred From: Oliver Neukum To: Jeffy Chen , linux-kernel@vger.kernel.org Cc: briannorris@chromium.org, dianders@chromium.org, Johan Hedberg , xiyou.wangcong@gmail.com, Marcel Holtmann , Gustavo Padovan , linux-bluetooth@vger.kernel.org Date: Mon, 24 Jul 2017 12:50:41 +0200 In-Reply-To: <1500548030-20556-1-git-send-email-jeffy.chen@rock-chips.com> References: <1500548030-20556-1-git-send-email-jeffy.chen@rock-chips.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 20.07.2017, 18:53 +0800 schrieb Jeffy Chen: > Currently we are calling usb_submit_urb directly to submit deferred tx > urbs after unanchor them. > > So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb > and cause memory leak: > unreferenced object 0xffffffc0ce0fa400 (size 256): > ... >   backtrace: >     [] __save_stack_trace+0x48/0x6c >     [] create_object+0x138/0x254 >     [] kmemleak_alloc+0x58/0x8c >     [] __kmalloc+0x1d4/0x2a0 >     [] usb_alloc_urb+0x30/0x60 >     [] alloc_ctrl_urb+0x38/0x120 [btusb] >     [] btusb_send_frame+0x64/0xf8 [btusb] > > Put those urbs in tx_anchor to avoid the leak, and also fix the error > handling. > > Signed-off-by: Jeffy Chen Reviewed-by: Oliver Neukum