From: Leonard Crestez <leonard.crestez@nxp.com>
To: Thomas Garnier <thgarnie@google.com>,
Russell King <linux@armlinux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
"Catalin Marinas" <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"Dave Martin" <Dave.Martin@arm.com>,
Chris Metcalf <cmetcalf@mellanox.com>,
Pratyush Anand <panand@redhat.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Kernel Hardening <kernel-hardening@lists.openwall.com>
Subject: Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop
Date: Tue, 25 Jul 2017 13:28:01 +0300 [thread overview]
Message-ID: <1500978481.30745.10.camel@nxp.com> (raw)
In-Reply-To: <CAJcbSZFw9GhVvNfYi1oHhpintHSzGcHvGjg5LtRViNBPDzLHaA@mail.gmail.com>
On Mon, 2017-07-24 at 10:07 -0700, Thomas Garnier wrote:
> On Wed, Jul 19, 2017 at 10:58 AM, Thomas Garnier <thgarnie@google.com
> > wrote:
> >
> > The work pending loop can call set_fs after addr_limit_user_check
> > removed the _TIF_FSCHECK flag. To prevent the infinite loop, move
> > the addr_limit_user_check call at the beginning of the loop.
> >
> > Fixes: 73ac5d6a2b6a ("arm/syscalls: Check address limit on user-
> > mode return")
> > Reported-by: Leonard Crestez <leonard.crestez@nxp.com>
> > Signed-off-by: Thomas Garnier <thgarnie@google.com>
> Any comments on this patch set?
Tested-by: Leonard Crestez <leonard.crestez@nxp.com>
This appears to fix the original issue of failing to boot from NFS when
there are lots of alignment faults. But this is a very basic test
relative to the reach of this change.
However the original patch has been in linux-next for a while and
apparently nobody else noticed system calls randomly hanging on arm.
I assume maintainers need to give their opinion.
next prev parent reply other threads:[~2017-07-25 10:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 17:58 [PATCH 1/3] arm/syscalls: Move address limit check in loop Thomas Garnier
2017-07-19 17:58 ` [PATCH 2/3] arm/syscalls: Optimize work flags assembly check Thomas Garnier
2017-07-19 17:59 ` [PATCH 3/3] arm64/syscalls: Move address limit check in loop Thomas Garnier
2017-07-24 17:07 ` [PATCH 1/3] arm/syscalls: " Thomas Garnier
2017-07-25 10:28 ` Leonard Crestez [this message]
2017-07-25 10:38 ` Russell King - ARM Linux
2017-07-25 20:01 ` Thomas Garnier
2017-07-26 12:02 ` Will Deacon
2017-07-26 14:20 ` Thomas Garnier
2017-07-26 18:25 ` Russell King - ARM Linux
2017-07-26 18:29 ` Thomas Garnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500978481.30745.10.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=Dave.Martin@arm.com \
--cc=catalin.marinas@arm.com \
--cc=cmetcalf@mellanox.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=panand@redhat.com \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox