From: Daniel Micay <danielmicay@gmail.com>
To: Kees Cook <keescook@chromium.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: kernel test robot <xiaolong.ye@intel.com>,
Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Mark Rutland <mark.rutland@arm.com>,
Daniel Axtens <dja@axtens.net>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Chris Metcalf <cmetcalf@ezchip.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, LKP <lkp@01.org>,
Joe Perches <joe@perches.com>
Subject: Re: [lkp-robot] [include/linux/string.h] 6974f0c455: kernel_BUG_at_lib/string.c
Date: Tue, 25 Jul 2017 22:37:52 -0400 [thread overview]
Message-ID: <1501036672.1196.5.camel@gmail.com> (raw)
In-Reply-To: <CAGXu5j+=WqBwLu3L8Um=5jfT=KOZX-GP0Nn1A9b8VZrYgiE+8Q@mail.gmail.com>
It was known that there are going to be bugs to work through, many of
them relatively benign like the leaks of data near string constants
(probably other string constants) in rodata. It makes sense to have it
default to WARN with BUG / noreturn as a non-default configuration
option for it, I guess with !COMPILE_TEST like UBSAN_SANITIZE_ALL. I
don't think there's any sane way to bound the length of either reads /
writes. It needs to either WARN + continue on into doing the overflow or
use BUG. Trying to correct it might make things worse and would make
this more complicated / bug-prone. It already has enough subtle edge
cases to deal with.
I think 'benign' is a better term than 'false positive' because there
hasn't been a non-bug found yet. They're mostly not security vulns but
they're undefined behavior.
prev parent reply other threads:[~2017-07-26 2:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 1:42 [lkp-robot] [include/linux/string.h] 6974f0c455: kernel_BUG_at_lib/string.c kernel test robot
2017-07-20 4:02 ` Daniel Micay
2017-07-20 4:04 ` Linus Torvalds
2017-07-20 4:41 ` Daniel Micay
2017-07-20 13:46 ` Masami Hiramatsu
2017-07-20 15:51 ` Masami Hiramatsu
2017-07-20 18:41 ` Linus Torvalds
2017-07-20 22:20 ` Masami Hiramatsu
2017-07-21 3:29 ` Masami Hiramatsu
2017-07-21 1:59 ` Ye Xiaolong
2017-07-21 5:48 ` Kees Cook
2017-07-21 9:15 ` Andy Shevchenko
2017-07-21 10:03 ` Petr Mladek
2017-07-25 23:35 ` Kees Cook
2017-07-26 0:11 ` Linus Torvalds
2017-07-26 0:38 ` Kees Cook
2017-07-26 2:37 ` Daniel Micay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501036672.1196.5.camel@gmail.com \
--to=danielmicay@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ananth@linux.vnet.ibm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arnd@arndb.de \
--cc=cmetcalf@ezchip.com \
--cc=dja@axtens.net \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lkp@01.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox