From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751840AbdG1MDU (ORCPT ); Fri, 28 Jul 2017 08:03:20 -0400 Received: from mout.gmx.net ([212.227.17.20]:56200 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbdG1MDT (ORCPT ); Fri, 28 Jul 2017 08:03:19 -0400 Message-ID: <1501243382.5386.4.camel@gmx.de> Subject: Re: [PATCH 0/2] KVM: nVMX: fixes to nested virt interrupt injection From: Mike Galbraith To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: jmattson@google.com, wanpeng.li@hotmail.com Date: Fri, 28 Jul 2017 14:03:02 +0200 In-Reply-To: References: <20170728070310.4460-1-pbonzini@redhat.com> <1501230295.9055.12.camel@gmx.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Yh+iN08S5zsUVq9XhDwtVNLlfqoKdMfZmFtzkrPM6OxOCyxYdOT 85Mc9ZtB6IhnSWIY2klePYo01HUcNuMzsGmdkyU68xBTLu7GWSWiJzEYsXi/kQGxtkIFdVb fVllqcXQVWjGucbdfW+Rd6zCZIinBb8zEl4Z/ThAN9i+eiThFqSF/jUdOiGQZqJbJzbQ/1y 6m5hFkNegQxkyZFdNrTYQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:FsbwQvUE/uc=:HwCV+nYFpK2zjTfQqAwScC lOaXgOzHMB38uUFunJE2WpkeqaeOnaAP+vd7ZBpKTi5AKCAy80Y0JWb3JtAXBIoj/BHjlVx7J n2UNCdP14ksbSDwRce3etpaWl5S1Yzd2YdPf6eW8cJC7eu0S3VNW+xtzOM5YRP7smpIFF6vob NsJH8TPoiwriJFXZG9BJKuIej772EFs7z1WA+N7f6CMdZq0uvukZCe4VfT2Vopo39dXJP3kHY UaVAFq7EfFs0J9VLTjy4auD0e/5gTbRcZozpsYYRsPaO919fTKSLX7Pjyt/t51VBvaOHWWsPp Sgxrz8gF1qaAmmN4VupLHF51/BwrKG215GbPE0ZJkW37cMqXYZYR2xVUaeInPdSTRvgBym6Ee 0AK9jVoRHF/QvWasoYPeGX0BvoukKezHQqD7f0qePyZL4y8RWGaMPKJf/gNmnDkSX341ATZJG vWf1ld2416GjoRTAFc3ywvRXhs1z+4UCAosvYQ/acRLZE+aaCGQPeDyBAozLRiYyLsAZ4wByH Ic5VEmiQlR5Fq2BtHUL3FkADbyGZe7ixAOXH4HYFRAEavsDklrj6qxRGD1K2tso6M5GqAU6PG nLhGW7pUexRaiBYaW+h7i47DPBg2TNhRosa40zMyP3r56BIosh3DJ9CeViMjm0Fpq3Lp+zmVU EjQSflMTGVE/p/u2n+a7DMWpUttTAFksdv0re9pFirhWq2xEKefjFH+zTSrhdhC9qXKk7ltpX jsPlPpeMLeIIaIuis2G7K7IUpOH2NG80xzgy+LgNIOC3zcc5bl8tMKHfseqL5y2qZoj0+6Vtg o6nPiii1IL9kQw0duOvBzVR31lDErPIXsIJk19GFIYgz3MCbtU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-07-28 at 13:53 +0200, Paolo Bonzini wrote: > On 28/07/2017 10:24, Mike Galbraith wrote: > > On Fri, 2017-07-28 at 09:03 +0200, Paolo Bonzini wrote: > >> With these two patches, KVM does not blindly pass the exit interruption > >> info and exit qualification from the vmcs02 and vmcs12 when injecting > >> an exception. There were two spots where this was done, namely > >> nested_vmx_check_exception and vmx_inject_page_fault_nested. > >> > >> Patch 1 avoids writing the vmcs02's VM_EXIT_INTR_ERROR_CODE field, > >> which as Jim noticed isn't possible on pre-Haswell machines, but > >> otherwise has no semantic effect. > >> > >> Patch 2 is the actual bugfix. > > > > I was looking into oodles of lapic_timer.hv_timer_in_use warnings in > > RT, introduced by KVM: LAPIC: Fix lapic timer injection delay, when I > > noticed this post. Happily, I can report that they are history. > > This patch won't fix them. They are a race that comes and goes---but > yes, it's fixed. Yes, I just discovered that they had merely gone into hiding. (and retrieved the patch that really really makes them dead)