From: Gustavo Padovan <gustavo.padovan@collabora.com>
To: Shuah Khan <shuahkh@osg.samsung.com>,
shuah@kernel.org, emilio.lopez@collabora.co.uk,
mpe@ellerman.id.au
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] selftests: sync test conversion to TAP13
Date: Fri, 28 Jul 2017 15:25:40 -0300 [thread overview]
Message-ID: <1501266340.14866.36.camel@collabora.com> (raw)
In-Reply-To: <cover.1500928925.git.shuahkh@osg.samsung.com>
Hi Shuah,
Thank you for your patches.
On Mon, 2017-07-24 at 15:07 -0600, Shuah Khan wrote:
> This patch series includes patches to convert sync test to use TAP13
> ksft framework. In addition, fix to sync test to differentiate
> between
> unsupported feature and access error when a non-root user runs it.
>
> Updated kfst framework to return counters for sync test to use to
> print
> the final pass or fail summary message. Updated ksft+print_cnts() to
> print counters to summarize the test results.
>
> Shuah Khan (3):
> selftests: sync: differentiate between sync unsupported and access
> errors
> selftests: kselftest framework: add API to return pass/fail/*
> counts
> selftests: sync: convert to use TAP13 ksft framework
>
> tools/testing/selftests/kselftest.h | 10 +++++
> tools/testing/selftests/sync/sync_test.c | 71 +++++++++++++++++++++-
> ----------
> tools/testing/selftests/sync/synctest.h | 3 +-
> 3 files changed, 58 insertions(+), 26 deletions(-)
All looks good to me, so for the 3 patches:
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Gustavo
--
Gustavo Padovan
Collabora Ltd.
next prev parent reply other threads:[~2017-07-28 18:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 21:07 [PATCH 0/3] selftests: sync test conversion to TAP13 Shuah Khan
2017-07-24 21:07 ` [PATCH 1/3] selftests: sync: differentiate between sync unsupported and access errors Shuah Khan
2017-07-24 21:07 ` [PATCH 2/3] selftests: kselftest framework: add API to return pass/fail/* counts Shuah Khan
2017-07-24 21:07 ` [PATCH 3/3] selftests: sync: convert to use TAP13 ksft framework Shuah Khan
2017-07-28 18:25 ` Gustavo Padovan [this message]
2017-07-28 19:12 ` [PATCH 0/3] selftests: sync test conversion to TAP13 Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501266340.14866.36.camel@collabora.com \
--to=gustavo.padovan@collabora.com \
--cc=emilio.lopez@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=shuah@kernel.org \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox