* [net-next PATCH] IB/hns: include linux/interrupt.h
@ 2017-07-28 13:35 Arnd Bergmann
2017-07-31 18:44 ` Doug Ledford
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-07-28 13:35 UTC (permalink / raw)
To: David S . Miller, Lijun Ou, Wei Hu(Xavier), Doug Ledford,
Sean Hefty, Hal Rosenstock
Cc: Florian Westphal, Arnd Bergmann, Salil, linux-rdma, linux-kernel
I ran into this build error on linux-next:
drivers/infiniband/hw/hns/hns_roce_eq.c:477:8: error: unknown type name 'irqreturn_t'
static irqreturn_t hns_roce_msi_x_interrupt(int irq, void *eq_ptr)
^~~~~~~~~~~
drivers/infiniband/hw/hns/hns_roce_eq.c: In function 'hns_roce_msi_x_interrupt':
drivers/infiniband/hw/hns/hns_roce_eq.c:485:9: error: implicit declaration of function 'IRQ_RETVAL'; did you mean 'BPF_RVAL'? [-Werror=implicit-function-declaration]
return IRQ_RETVAL(int_work);
I have bisected this to a seemingly unrelated change that happened
to remove some indirect header inclusions. Simply including the
required header explicitly fixes the build failure.
Fixes: 09c7570480f7 ("xfrm: remove flow cache")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/infiniband/hw/hns/hns_roce_eq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/hns/hns_roce_eq.c b/drivers/infiniband/hw/hns/hns_roce_eq.c
index 50f864935a0e..b39d14b62355 100644
--- a/drivers/infiniband/hw/hns/hns_roce_eq.c
+++ b/drivers/infiniband/hw/hns/hns_roce_eq.c
@@ -31,6 +31,7 @@
*/
#include <linux/platform_device.h>
+#include <linux/interrupt.h>
#include "hns_roce_common.h"
#include "hns_roce_device.h"
#include "hns_roce_eq.h"
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net-next PATCH] IB/hns: include linux/interrupt.h
2017-07-28 13:35 [net-next PATCH] IB/hns: include linux/interrupt.h Arnd Bergmann
@ 2017-07-31 18:44 ` Doug Ledford
0 siblings, 0 replies; 2+ messages in thread
From: Doug Ledford @ 2017-07-31 18:44 UTC (permalink / raw)
To: Arnd Bergmann, David S . Miller, Lijun Ou, Wei Hu(Xavier),
Sean Hefty, Hal Rosenstock
Cc: Florian Westphal, Salil, linux-rdma, linux-kernel
On Fri, 2017-07-28 at 15:35 +0200, Arnd Bergmann wrote:
> I ran into this build error on linux-next:
>
> drivers/infiniband/hw/hns/hns_roce_eq.c:477:8: error: unknown type
> name 'irqreturn_t'
> static irqreturn_t hns_roce_msi_x_interrupt(int irq, void *eq_ptr)
> ^~~~~~~~~~~
> drivers/infiniband/hw/hns/hns_roce_eq.c: In function
> 'hns_roce_msi_x_interrupt':
> drivers/infiniband/hw/hns/hns_roce_eq.c:485:9: error: implicit
> declaration of function 'IRQ_RETVAL'; did you mean 'BPF_RVAL'? [-
> Werror=implicit-function-declaration]
> return IRQ_RETVAL(int_work);
>
> I have bisected this to a seemingly unrelated change that happened
> to remove some indirect header inclusions. Simply including the
> required header explicitly fixes the build failure.
>
> Fixes: 09c7570480f7 ("xfrm: remove flow cache")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-31 18:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-28 13:35 [net-next PATCH] IB/hns: include linux/interrupt.h Arnd Bergmann
2017-07-31 18:44 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox