From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751227AbdGaSoK (ORCPT <rfc822;w@1wt.eu>);
        Mon, 31 Jul 2017 14:44:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60690 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750967AbdGaSoJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 31 Jul 2017 14:44:09 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7952CC1D7A3F
Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dledford@redhat.com
Message-ID: <1501526645.2725.0.camel@redhat.com>
Subject: Re: [net-next PATCH] IB/hns: include linux/interrupt.h
From: Doug Ledford <dledford@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>,
        "David S . Miller" <davem@davemloft.net>,
        Lijun Ou <oulijun@huawei.com>,
        "Wei Hu(Xavier)" <xavier.huwei@huawei.com>,
        Sean Hefty <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>
Cc: Florian Westphal <fw@strlen.de>, Salil <salil.mehta@huawei.com>,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Mon, 31 Jul 2017 14:44:05 -0400
In-Reply-To: <20170728133539.516824-1-arnd@arndb.de>
References: <20170728133539.516824-1-arnd@arndb.de>
Organization: Red Hat, Inc.
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 31 Jul 2017 18:44:08 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2017-07-28 at 15:35 +0200, Arnd Bergmann wrote:
> I ran into this build error on linux-next:
> 
> drivers/infiniband/hw/hns/hns_roce_eq.c:477:8: error: unknown type
> name 'irqreturn_t'
>  static irqreturn_t hns_roce_msi_x_interrupt(int irq, void *eq_ptr)
>         ^~~~~~~~~~~
> drivers/infiniband/hw/hns/hns_roce_eq.c: In function
> 'hns_roce_msi_x_interrupt':
> drivers/infiniband/hw/hns/hns_roce_eq.c:485:9: error: implicit
> declaration of function 'IRQ_RETVAL'; did you mean 'BPF_RVAL'? [-
> Werror=implicit-function-declaration]
>   return IRQ_RETVAL(int_work);
> 
> I have bisected this to a seemingly unrelated change that happened
> to remove some indirect header inclusions. Simply including the
> required header explicitly fixes the build failure.
> 
> Fixes: 09c7570480f7 ("xfrm: remove flow cache")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD