From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] get_maintainer: Prepare for separate MAINTAINERS files
Date: Wed, 02 Aug 2017 13:35:49 -0700 [thread overview]
Message-ID: <1501706149.31625.10.camel@perches.com> (raw)
In-Reply-To: <CA+55aFxXsxUfxVj=arMk65s4k9Om6_sPnfKAyN3gY5FzX21S9Q@mail.gmail.com>
On Wed, 2017-08-02 at 11:15 -0700, Linus Torvalds wrote:
> On Wed, Aug 2, 2017 at 11:06 AM, Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > IMO, the parse-maintainters.pl (sorting) script makes the need for separate
> > MAINTAINERS files much less important since the file can be "fixed" easily
> > at any time.
>
> For me it's not the "fixing". It's the inevitable merge mess, and the
> two hundred commits that I have to go through.
>
> That said, the extra time just to look for MAINTAINERS files makes me
> unhappy. It may be just .3s on Joe's machine, but it's presumably much
> more when things aren't in the filesystem caches. I (like apparently
> Joe) have an SSD so it's not a big deal for me, but..
>
> Just having a single MAINTAINERS directory would alleviate that concern.
Yeah. Quite a bit. With an i5-6200 and an SSD:
Looking for all MAINTAINERS files:
Cold cache find:
$ time find . -not \( -path ./.git -prune \) -name MAINTAINERS
./drivers/staging/unisys/MAINTAINERS
./MAINTAINERS
real 0m3.129s
user 0m0.368s
sys 0m0.828s
Warm cache find:
$ time find . -not \( -path ./.git -prune \) -name MAINTAINERS
./drivers/staging/unisys/MAINTAINERS
./MAINTAINERS
real 0m0.151s
user 0m0.084s
sys 0m0.064s
vs looking for all files in MAINTAINERS directory
Cold cache:
$ time find MAINTAINERS.tmp/ | wc -l
1736
real 0m0.037s
user 0m0.016s
sys 0m0.012s
Warm cache:
$ time find MAINTAINERS.tmp/ | wc -l
1736
real 0m0.017s
user 0m0.012s
sys 0m0.008s
next prev parent reply other threads:[~2017-08-02 20:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-23 20:32 [PATCH V2] get_maintainer: Prepare for separate MAINTAINERS files Joe Perches
2017-08-02 8:04 ` Joe Perches
2017-08-02 18:06 ` Randy Dunlap
2017-08-02 18:15 ` Linus Torvalds
2017-08-02 20:35 ` Joe Perches [this message]
2017-08-14 22:09 ` Pavel Machek
2017-08-15 0:58 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501706149.31625.10.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox